ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

InputRoll - rip out the UseCustomBackGround flag, and only key off the existence of the override. Seems to be a speed hack, but the only attempt to make it faster (in ram watch) was actually making things slower

This commit is contained in:
adelikat 2019-11-26 12:33:39 -06:00
parent a45b33b8c6
commit 56b33498d9
11 changed files with 1 additions and 41 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
BizHawk.Client.EmuHawk/CustomControls/InputRoll/InputRoll.Drawing.cs
View File

@ -459,7 +459,7 @@ namespace BizHawk.Client.EmuHawk
/// </summary>
private void DrawBg(List<RollColumn> visibleColumns)
{
if (UseCustomBackground && QueryItemBkColor != null)
if (QueryItemBkColor != null)
{
DoBackGroundCallback(visibleColumns);
}

5
BizHawk.Client.EmuHawk/CustomControls/InputRoll/InputRoll.cs
View File

@ -76,7 +76,6 @@ namespace BizHawk.Client.EmuHawk
public InputRoll()
{
UseCustomBackground = true;
GridLines = true;
CellWidthPadding = 3;
CellHeightPadding = 0;
@ -583,10 +582,6 @@ namespace BizHawk.Client.EmuHawk
[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
public bool IsPaintDown { get; private set; }
[Browsable(false)]
[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
public bool UseCustomBackground { get; set; }
[Browsable(false)]
[DesignerSerializationVisibility(DesignerSerializationVisibility.Hidden)]
public int DrawHeight { get; private set; }

1
BizHawk.Client.EmuHawk/tools/CDL.designer.cs generated
View File

@ -275,7 +275,6 @@
this.lvCDL.Name = "lvCDL";
this.lvCDL.Size = new System.Drawing.Size(992, 323);
this.lvCDL.TabIndex = 9;
this.lvCDL.UseCustomBackground = true;
this.lvCDL.AllowColumnReorder = false;
this.lvCDL.AllowColumnResize = true;
this.lvCDL.QueryItemText += new InputRoll.QueryItemTextHandler(this.lvCDL_QueryItemText);

1
BizHawk.Client.EmuHawk/tools/Cheats/Cheats.Designer.cs generated
View File

@ -109,7 +109,6 @@
this.CheatListView.Name = "CheatListView";
this.CheatListView.Size = new System.Drawing.Size(414, 321);
this.CheatListView.TabIndex = 1;
this.CheatListView.UseCustomBackground = true;
this.CheatListView.ColumnClick += new BizHawk.Client.EmuHawk.InputRoll.ColumnClickEventHandler(this.CheatListView_ColumnClick);
this.CheatListView.SelectedIndexChanged += new System.EventHandler(this.CheatListView_SelectedIndexChanged);
this.CheatListView.DragDrop += new System.Windows.Forms.DragEventHandler(this.NewCheatForm_DragDrop);

1
BizHawk.Client.EmuHawk/tools/Debugger/GenericDebugger.Designer.cs generated
View File

@ -248,7 +248,6 @@
this.DisassemblerView.Name = "DisassemblerView";
this.DisassemblerView.Size = new System.Drawing.Size(395, 476);
this.DisassemblerView.TabIndex = 1;
this.DisassemblerView.UseCustomBackground = true;
this.DisassemblerView.RowScroll += new InputRoll.RowScrollEvent(this.DisassemblerView_Scroll);
this.DisassemblerView.SizeChanged += new System.EventHandler(this.DisassemblerView_SizeChanged);
this.DisassemblerView.KeyDown += new System.Windows.Forms.KeyEventHandler(this.DisassemblerView_KeyDown);

1
BizHawk.Client.EmuHawk/tools/Lua/LuaConsole.Designer.cs generated
View File

@ -812,7 +812,6 @@
this.LuaListView.Name = "LuaListView";
this.LuaListView.Size = new System.Drawing.Size(273, 271);
this.LuaListView.TabIndex = 0;
this.LuaListView.UseCustomBackground = true;
this.LuaListView.ColumnClick += new BizHawk.Client.EmuHawk.InputRoll.ColumnClickEventHandler(this.LuaListView_ColumnClick);
this.LuaListView.KeyDown += new System.Windows.Forms.KeyEventHandler(this.LuaListView_KeyDown);
this.LuaListView.DoubleClick += new System.EventHandler(this.LuaListView_DoubleClick);

1
BizHawk.Client.EmuHawk/tools/TAStudio/UndoHistoryForm.Designer.cs generated
View File

@ -172,7 +172,6 @@
this.HistoryView.Name = "HistoryView";
this.HistoryView.Size = new System.Drawing.Size(369, 213);
this.HistoryView.TabIndex = 2;
this.HistoryView.UseCustomBackground = true;
this.HistoryView.DoubleClick += new System.EventHandler(this.HistoryView_DoubleClick);
this.HistoryView.MouseDown += new System.Windows.Forms.MouseEventHandler(this.HistoryView_MouseDown);
this.HistoryView.MouseUp += new System.Windows.Forms.MouseEventHandler(this.HistoryView_MouseUp);

1
BizHawk.Client.EmuHawk/tools/TraceLogger.Designer.cs generated
View File

@ -89,7 +89,6 @@
this.TraceView.Size = new System.Drawing.Size(603, 414);
this.TraceView.TabIndex = 4;
this.TraceView.TabStop = false;
this.TraceView.UseCustomBackground = true;
this.TraceView.AllowColumnResize = true;
this.TraceView.AllowColumnReorder = false;
//

1
BizHawk.Client.EmuHawk/tools/Watch/RamSearch.Designer.cs generated
View File

@ -193,7 +193,6 @@
this.WatchListView.Name = "WatchListView";
this.WatchListView.Size = new System.Drawing.Size(230, 366);
this.WatchListView.TabIndex = 1;
this.WatchListView.UseCustomBackground = true;
this.WatchListView.MultiSelect = true;
this.WatchListView.ColumnClick += new BizHawk.Client.EmuHawk.InputRoll.ColumnClickEventHandler(this.WatchListView_ColumnClick);
this.WatchListView.SelectedIndexChanged += new System.EventHandler(this.WatchListView_SelectedIndexChanged);

1
BizHawk.Client.EmuHawk/tools/Watch/RamWatch.Designer.cs generated
View File

@ -894,7 +894,6 @@
this.WatchListView.Name = "WatchListView";
this.WatchListView.Size = new System.Drawing.Size(363, 281);
this.WatchListView.TabIndex = 2;
this.WatchListView.UseCustomBackground = true;
this.WatchListView.ColumnClick += new BizHawk.Client.EmuHawk.InputRoll.ColumnClickEventHandler(this.WatchListView_ColumnClick);
this.WatchListView.SelectedIndexChanged += new System.EventHandler(this.WatchListView_SelectedIndexChanged);
this.WatchListView.DragDrop += new System.Windows.Forms.DragEventHandler(this.RamWatch_DragDrop);

27
BizHawk.Client.EmuHawk/tools/Watch/RamWatch.cs
View File

@ -266,37 +266,10 @@ namespace BizHawk.Client.EmuHawk
return;
}
WatchListView.UseCustomBackground = NeedsBackground;
WatchListView.Invalidate();
}
}
private bool NeedsBackground
{
get
{
foreach (var watch in _watches)
{
if (watch.IsSeparator)
{
return true;
}
if (Global.CheatList.IsActive(watch.Domain, watch.Address))
{
return true;
}
if (watch.IsOutOfRange)
{
return true;
}
}
return false;
}
}
public void FastUpdate()
{
if (_paused)