ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Get rid of unnecessary CRC32Checksum.cs 

haven't checked for correctness or regressions
This commit is contained in:
Morilli 2021-12-12 17:51:54 +01:00
parent d979a09f5a
commit 558adfa325
6 changed files with 3 additions and 39 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

33
src/BizHawk.Common/checksums/CRC32Checksum.cs
View File

@ -1,33 +0,0 @@
using System;
using BizHawk.Common.BufferExtensions;
namespace BizHawk.Common
{
/// <summary>uses <see cref="CRC32">custom implementation</see> of CRC-32 (i.e. POSIX cksum)</summary>
/// <seealso cref="MD5Checksum"/>
/// <seealso cref="SHA1Checksum"/>
/// <seealso cref="SHA256Checksum"/>
public static class CRC32Checksum
{
/// <remarks>in bits</remarks>
internal const int EXPECTED_LENGTH = 32;
internal const string PREFIX = "CRC32";
public static byte[] BytesAsDigest(uint digest)
{
var a = BitConverter.GetBytes(digest);
return new[] { a[3], a[2], a[1], a[0] };
}
public static byte[] Compute(ReadOnlySpan<byte> data)
=> BytesAsDigest(CRC32.Calculate(data));
public static string ComputeDigestHex(ReadOnlySpan<byte> data)
=> Compute(data).BytesToHexString();
public static string ComputePrefixedHex(ReadOnlySpan<byte> data)
=> $"{PREFIX}:{ComputeDigestHex(data)}";
}
}

1
src/BizHawk.Common/checksums/MD5Checksum.cs
View File

@ -7,7 +7,6 @@ using BizHawk.Common.BufferExtensions;
namespace BizHawk.Common
{
/// <summary>uses <see cref="MD5"/> implementation from BCL</summary>
/// <seealso cref="CRC32Checksum"/>
/// <seealso cref="SHA1Checksum"/>
/// <seealso cref="SHA256Checksum"/>
public static class MD5Checksum

1
src/BizHawk.Common/checksums/SHA1Checksum.cs
View File

@ -7,7 +7,6 @@ using BizHawk.Common.BufferExtensions;
namespace BizHawk.Common
{
/// <summary>uses <see cref="SHA1"/> implementation from BCL</summary>
/// <seealso cref="CRC32Checksum"/>
/// <seealso cref="MD5Checksum"/>
/// <seealso cref="SHA256Checksum"/>
public static class SHA1Checksum

1
src/BizHawk.Common/checksums/SHA256Checksum.cs
View File

@ -7,7 +7,6 @@ using BizHawk.Common.BufferExtensions;
namespace BizHawk.Common
{
/// <summary>uses <see cref="SHA256"/> implementation from BCL</summary>
/// <seealso cref="CRC32Checksum"/>
/// <seealso cref="MD5Checksum"/>
/// <seealso cref="SHA1Checksum"/>
public static class SHA256Checksum

2
src/BizHawk.Emulation.Common/Database/Database.cs
View File

@ -190,7 +190,7 @@ namespace BizHawk.Emulation.Common
{
acquire.WaitOne();
var hashCRC32 = CRC32Checksum.ComputeDigestHex(romData);
var hashCRC32 = CRC32.Calculate(romData).ToString("X8");
if (DB.TryGetValue(hashCRC32, out var cgi))
{
return new GameInfo(cgi);

4
src/BizHawk.Emulation.DiscSystem/DiscHasher.cs
View File

@ -54,7 +54,7 @@ namespace BizHawk.Emulation.DiscSystem
crc.Add(buffer2352);
}
return CRC32Checksum.BytesAsDigest(crc.Result).BytesToHexString();
return crc.Result.ToString("X8");
}
/// <summary>
@ -102,4 +102,4 @@ namespace BizHawk.Emulation.DiscSystem
return "no data track found";
}
}
}
}