From 54d33b09ee43f15e806acae39ed2473ea4931180 Mon Sep 17 00:00:00 2001 From: YoshiRulz Date: Mon, 24 Feb 2025 10:34:37 +1000 Subject: [PATCH] Fix code style warnings in ext. tools see 69b923ad5 --- ExternalToolProjects/DATParser/DATConverter.cs | 2 +- ExternalToolProjects/DBMan/DiscHash.cs | 5 +++-- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/ExternalToolProjects/DATParser/DATConverter.cs b/ExternalToolProjects/DATParser/DATConverter.cs index 6f06d3a16a..bf8eb63c76 100644 --- a/ExternalToolProjects/DATParser/DATConverter.cs +++ b/ExternalToolProjects/DATParser/DATConverter.cs @@ -106,7 +106,7 @@ namespace BizHawk.DATTool foreach (var s in listBoxFiles.Items) { - if (s.ToString().Trim() == "") + if (string.IsNullOrWhiteSpace(s.ToString())) { MessageBox.Show($"The selected file: {s}Cannot be found.\n\nSort this out and try again"); return; diff --git a/ExternalToolProjects/DBMan/DiscHash.cs b/ExternalToolProjects/DBMan/DiscHash.cs index 3f0395542c..08c70d08f8 100644 --- a/ExternalToolProjects/DBMan/DiscHash.cs +++ b/ExternalToolProjects/DBMan/DiscHash.cs @@ -5,6 +5,7 @@ using System.Threading.Tasks; using System.IO; using System.Collections.Generic; +using BizHawk.Common.StringExtensions; using BizHawk.Emulation.DiscSystem; namespace BizHawk.DBManTool @@ -24,7 +25,7 @@ namespace BizHawk.DBManTool dpCurr = dpTodo.Dequeue(); Parallel.ForEach(new DirectoryInfo(dpCurr).GetFiles(), (fi) => { - if (fi.Extension.ToUpperInvariant() == extUppercaseWithDot) + if (extUppercaseWithDot.EqualsIgnoreCase(fi.Extension)) lock (ret) ret.Add(fi.FullName); }); @@ -59,7 +60,7 @@ namespace BizHawk.DBManTool var done = new HashSet(); foreach (var line in File.ReadAllLines(fpOutfile)) { - if (line.Trim() == "") continue; + if (string.IsNullOrWhiteSpace(line)) continue; var parts = line.Split(new[] { "//" }, StringSplitOptions.None); done.Add(parts[1]); }