From 5493904312951e2d46ef32b8ef558c00ed04e723 Mon Sep 17 00:00:00 2001 From: zeromus Date: Sat, 10 Mar 2012 05:30:53 +0000 Subject: [PATCH] new-fix a recently created ppu bug affecting some vertical scrolling --- BizHawk.Emulation/Consoles/Nintendo/NES/PPU.regs.cs | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/BizHawk.Emulation/Consoles/Nintendo/NES/PPU.regs.cs b/BizHawk.Emulation/Consoles/Nintendo/NES/PPU.regs.cs index 16d74ad23a..84796e3d1b 100644 --- a/BizHawk.Emulation/Consoles/Nintendo/NES/PPU.regs.cs +++ b/BizHawk.Emulation/Consoles/Nintendo/NES/PPU.regs.cs @@ -230,12 +230,13 @@ namespace BizHawk.Emulation.Consoles.Nintendo public void increment2007(bool rendering, bool by32) { - //new knowledge as of 2010 - use this incrementing method while rendering is active (thanks, nemulator) - //http://nesdev.parodius.com/bbs/viewtopic.php?t=6401 if (rendering) { - if (by32) increment_vs(); - else increment_hsc(); + //don't do this: + //if (by32) increment_vs(); + //else increment_hsc(); + //do this instead: + increment_vs(); //yes, even if we're moving by 32 return; } @@ -493,6 +494,7 @@ namespace BizHawk.Emulation.Consoles.Nintendo nes.board.AddressPPU(addr); + nes.LogLine("read 2007"); ppur.increment2007(ppur.status.rendering && reg_2001.PPUON, reg_2000.vram_incr32 != 0); return ret;