diff --git a/.global.editorconfig.ini b/.global.editorconfig.ini index 0f0125bb50..8f9c795fee 100644 --- a/.global.editorconfig.ini +++ b/.global.editorconfig.ini @@ -346,6 +346,8 @@ dotnet_diagnostic.MA0155.severity = error dotnet_diagnostic.MA0156.severity = error # Do not use 'Async' suffix when a method does not return IAsyncEnumerable dotnet_diagnostic.MA0157.severity = error +# Use ContainsKey instead of TryGetValue +dotnet_diagnostic.MA0160.severity = warning ## Menees.Analyzers rules diff --git a/Directory.Packages.props b/Directory.Packages.props index 0459d3107f..ab9017e162 100644 --- a/Directory.Packages.props +++ b/Directory.Packages.props @@ -7,7 +7,7 @@ - + diff --git a/Dist/deps.nix b/Dist/deps.nix index c66aff8d44..a558ff5ea8 100644 --- a/Dist/deps.nix +++ b/Dist/deps.nix @@ -9,7 +9,7 @@ (fetchNuGet { pname = "ImGui.NET"; version = "1.90.6.1"; sha256 = "1v1zzlpz3g2h7azqqqhfcwssx9vminnb5pl9880jw28mfk5si1q8"; }) (fetchNuGet { pname = "JunitXml.TestLogger"; version = "3.1.12"; sha256 = "1571rs2zpd7az5wp0bklx1h3pac388awlwhz70k0p0vv44h0v5jc"; }) (fetchNuGet { pname = "Menees.Analyzers"; version = "3.2.2"; sha256 = "0zd7hh5xilm1svnz4dcvgryixkmsncdszzimy3fvz2xbs06cpksb"; }) - (fetchNuGet { pname = "Meziantou.Analyzer"; version = "2.0.159"; sha256 = "0ybck0h871hdb7lfv52f73a1y1v2nrlvbvbmy2ws5nbd0xacjvww"; }) + (fetchNuGet { pname = "Meziantou.Analyzer"; version = "2.0.163"; sha256 = "1nzn3j7dbbs101mwjksfmb06fnxzwpl4s2n1yi9cwlr9mhnqf33k"; }) (fetchNuGet { pname = "Microsoft.ApplicationInsights"; version = "2.22.0"; sha256 = "0h5qkhmazlvwvjmxxj9pp2404rmvk55yf6npwcmlskv9mgfkli4r"; }) (fetchNuGet { pname = "Microsoft.Bcl.AsyncInterfaces"; version = "8.0.0"; sha256 = "0z4jq5prnxyb4p3163yxx35znpd2msjd8hw8ysmv4ah90f5sd9gm"; }) (fetchNuGet { pname = "Microsoft.Bcl.HashCode"; version = "1.1.1"; sha256 = "0xwfph92p92d8hgrdiaka4cazqsjpg4ywfxfx6qbk3939f29kzl0"; }) diff --git a/src/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/Unif.cs b/src/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/Unif.cs index b625198f70..4fab8b9a78 100644 --- a/src/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/Unif.cs +++ b/src/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/Unif.cs @@ -89,7 +89,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.NES Cart.BoardType = Cart.BoardType.TrimEnd('\0'); Cart.BoardType = "UNIF_" + Cart.BoardType; - if (Chunks.TryGetValue("BATR", out _)) + if (Chunks.ContainsKey("BATR")) { // apparently, this chunk just existing means battery is yes Cart.WramBattery = true;