From 4c00ec54e75389e3a61ed4638fb941e3d3d8500b Mon Sep 17 00:00:00 2001
From: Morilli <35152647+Morilli@users.noreply.github.com>
Date: Thu, 8 Jun 2023 18:34:56 +0200
Subject: [PATCH] Bump AnalysisLevel, remove legacy rules

---
 Common.props   |   3 +-
 Common.ruleset | 227 -------------------------------------------------
 2 files changed, 1 insertion(+), 229 deletions(-)

diff --git a/Common.props b/Common.props
index e95792861b..36c0d9057e 100644
--- a/Common.props
+++ b/Common.props
@@ -1,6 +1,6 @@
 <Project>
 	<PropertyGroup>
-		<AnalysisLevel>5</AnalysisLevel>
+		<AnalysisLevel>6</AnalysisLevel>
 		<CodeAnalysisRuleSet>$(MSBuildProjectDirectory)/../../Common.ruleset</CodeAnalysisRuleSet>
 		<ContinuousIntegrationBuild Condition=" '$(GITLAB_CI)' != '' Or '$(APPVEYOR)' != '' ">true</ContinuousIntegrationBuild>
 		<EnableNETAnalyzers>true</EnableNETAnalyzers>
@@ -12,7 +12,6 @@
 		<Nullable>enable</Nullable>
 		<PlatformTarget>AnyCPU</PlatformTarget>
 		<RunAnalyzersDuringBuild>true</RunAnalyzersDuringBuild>
-		<RunCodeAnalysis>false</RunCodeAnalysis>
 	</PropertyGroup>
 	<PropertyGroup Condition=" '$(Configuration)' == 'Debug' ">
 		<DebugSymbols>true</DebugSymbols>
diff --git a/Common.ruleset b/Common.ruleset
index cc498e204c..c0d05e8bfa 100644
--- a/Common.ruleset
+++ b/Common.ruleset
@@ -461,233 +461,6 @@
 		<!-- Use the Regex source generator -->
 		<Rule Id="MA0110" Action="Error" />
 	</Rules>
-	<Rules AnalyzerId="Microsoft.CodeAnalysis.FxCopAnalyzers" RuleNamespace="Microsoft.CodeAnalysis.FxCopAnalyzers">
-		<!-- Types that own disposable fields should be disposable -->
-		<Rule Id="CA1001" Action="Hidden" />
-
-		<!-- Mark assemblies with assembly version -->
-		<Rule Id="CA1016" Action="Warning" />
-
-		<!-- Enum Storage should be Int32 -->
-		<Rule Id="CA1028" Action="Hidden" />
-
-		<!-- Use events where appropriate -->
-		<Rule Id="CA1030" Action="Hidden" />
-
-		<!-- Do not catch general exception types -->
-		<Rule Id="CA1031" Action="Hidden" />
-
-		<!-- Implement standard exception constructors -->
-		<Rule Id="CA1032" Action="Hidden" />
-
-		<!-- Nested types should not be visible -->
-		<Rule Id="CA1034" Action="Hidden" />
-
-		<!-- Override methods on comparable types -->
-		<Rule Id="CA1036" Action="Hidden" />
-
-		<!-- Avoid empty interfaces -->
-		<Rule Id="CA1040" Action="Hidden" />
-
-		<!-- Provide ObsoleteAttribute message -->
-		<Rule Id="CA1041" Action="Hidden" />
-
-		<!-- Use Integral Or String Argument For Indexers -->
-		<Rule Id="CA1043" Action="Hidden" />
-
-		<!-- Properties should not be write only -->
-		<Rule Id="CA1044" Action="Error" />
-
-		<!-- Do not declare visible instance fields -->
-		<Rule Id="CA1051" Action="Hidden" />
-
-		<!-- Uri parameters should not be strings -->
-		<Rule Id="CA1054" Action="Hidden" />
-
-		<!-- Uri return values should not be strings -->
-		<Rule Id="CA1055" Action="Hidden" />
-
-		<!-- Uri properties should not be strings -->
-		<Rule Id="CA1056" Action="Hidden" />
-
-		<!-- Validate arguments of public methods -->
-		<Rule Id="CA1062" Action="Hidden" />
-
-		<!-- Implement IDisposable Correctly -->
-		<Rule Id="CA1063" Action="Hidden" />
-
-		<!-- Exceptions should be public -->
-		<Rule Id="CA1064" Action="Error" />
-
-		<!-- Do not raise exceptions in unexpected locations -->
-		<Rule Id="CA1065" Action="Hidden" />
-
-		<!-- Type {0} should implement IEquatable<T> because it overrides Equals -->
-		<Rule Id="CA1066" Action="Hidden" />
-
-		<!-- Enums values should not be duplicated -->
-		<Rule Id="CA1069" Action="Hidden" />
-
-		<!-- Do not pass literals as localized parameters -->
-		<Rule Id="CA1303" Action="Hidden" />
-
-		<!-- Specify CultureInfo -->
-		<Rule Id="CA1304" Action="Hidden" />
-
-		<!-- Specify IFormatProvider -->
-		<Rule Id="CA1305" Action="Hidden" />
-
-		<!-- Specify StringComparison -->
-		<Rule Id="CA1307" Action="Hidden" />
-
-		<!-- Normalize strings to uppercase -->
-		<Rule Id="CA1308" Action="Hidden" />
-
-		<!-- P/Invokes should not be visible -->
-		<Rule Id="CA1401" Action="Hidden" />
-
-		<!-- Use nameof to express symbol names -->
-		<Rule Id="CA1507" Action="Hidden" />
-
-		<!-- Identifiers should not contain underscores -->
-		<Rule Id="CA1707" Action="Hidden" />
-
-		<!-- Identifiers should have correct suffix -->
-		<Rule Id="CA1710" Action="Hidden" />
-
-		<!-- Do not prefix enum values with type name -->
-		<Rule Id="CA1712" Action="Hidden" />
-
-		<!-- Events should not have 'Before' or 'After' prefix -->
-		<Rule Id="CA1713" Action="Hidden" />
-
-		<!-- Flags enums should have plural names -->
-		<Rule Id="CA1714" Action="Hidden" />
-
-		<!-- Identifiers should have correct prefix -->
-		<Rule Id="CA1715" Action="Hidden" />
-
-		<!-- Identifiers should not match keywords -->
-		<Rule Id="CA1716" Action="Hidden" />
-
-		<!-- Only FlagsAttribute enums should have plural names -->
-		<Rule Id="CA1717" Action="Hidden" />
-
-		<!-- Identifier contains type name -->
-		<Rule Id="CA1720" Action="Hidden" />
-
-		<!-- Property names should not match get methods -->
-		<Rule Id="CA1721" Action="Hidden" />
-
-		<!-- Type names should not match namespaces -->
-		<Rule Id="CA1724" Action="Hidden" />
-
-		<!-- Review unused parameters -->
-		<Rule Id="CA1801" Action="Hidden" />
-
-		<!-- Use literals where appropriate -->
-		<Rule Id="CA1802" Action="Hidden" />
-
-		<!-- Do not initialize unnecessarily -->
-		<Rule Id="CA1805" Action="Hidden" />
-
-		<!-- Do not ignore method results -->
-		<Rule Id="CA1806" Action="Error" />
-
-		<!-- Initialize reference type static fields inline -->
-		<Rule Id="CA1810" Action="Hidden" />
-
-		<!-- Avoid uninstantiated internal classes -->
-		<Rule Id="CA1812" Action="Hidden" />
-
-		<!-- Prefer jagged arrays over multidimensional -->
-		<Rule Id="CA1814" Action="Hidden" />
-
-		<!-- Override equals and operator equals on value types -->
-		<Rule Id="CA1815" Action="Hidden" />
-
-		<!-- Dispose methods should call SuppressFinalize -->
-		<Rule Id="CA1816" Action="Hidden" />
-
-		<!-- Properties should not return arrays -->
-		<Rule Id="CA1819" Action="Hidden" />
-
-		<!-- Test for empty strings using string length -->
-		<Rule Id="CA1820" Action="Hidden" />
-
-		<!-- Mark members as static -->
-		<Rule Id="CA1822" Action="Hidden" />
-
-		<!-- Avoid unused private fields -->
-		<Rule Id="CA1823" Action="Hidden" />
-
-		<!-- Avoid zero-length array allocations. -->
-		<Rule Id="CA1825" Action="Error" />
-
-		<!-- Do not use Count() or LongCount() when Any() can be used -->
-		<Rule Id="CA1827" Action="Error" />
-
-		<!-- Dispose objects before losing scope -->
-		<Rule Id="CA2000" Action="Hidden" />
-
-		<!-- Do not lock on objects with weak identity -->
-		<Rule Id="CA2002" Action="Hidden" />
-
-		<!-- Do not use stackalloc in loops -->
-		<Rule Id="CA2014" Action="Error" />
-
-		<!-- Review SQL queries for security vulnerabilities -->
-		<Rule Id="CA2100" Action="Hidden" />
-
-		<!-- Specify marshaling for P/Invoke string arguments -->
-		<Rule Id="CA2101" Action="Hidden" />
-
-		<!-- Instantiate argument exceptions correctly -->
-		<Rule Id="CA2208" Action="Error" />
-
-		<!-- Non-constant fields should not be visible -->
-		<Rule Id="CA2211" Action="Hidden" />
-
-		<!-- Disposable fields should be disposed -->
-		<Rule Id="CA2213" Action="Hidden" />
-
-		<!-- Do not call overridable methods in constructors -->
-		<Rule Id="CA2214" Action="Error" />
-
-		<!-- Disposable types should declare finalizer -->
-		<Rule Id="CA2216" Action="Hidden" />
-
-		<!-- Operator overloads have named alternates -->
-		<Rule Id="CA2225" Action="Hidden" />
-
-		<!-- Collection properties should be read only -->
-		<Rule Id="CA2227" Action="Hidden" />
-
-		<!-- Implement serialization constructors -->
-		<Rule Id="CA2229" Action="Hidden" />
-
-		<!-- Pass system uri objects instead of strings -->
-		<Rule Id="CA2234" Action="Hidden" />
-
-		<!-- Mark ISerializable types with serializable -->
-		<Rule Id="CA2237" Action="Hidden" />
-
-		<!-- Provide correct arguments to formatting methods -->
-		<Rule Id="CA2241" Action="Hidden" />
-
-		<!-- Attribute string literals should parse correctly -->
-		<Rule Id="CA2243" Action="Hidden" />
-
-		<!-- Insecure DTD processing in XML -->
-		<Rule Id="CA3075" Action="Hidden" />
-
-		<!-- Do Not Use Weak Cryptographic Algorithms -->
-		<Rule Id="CA5350" Action="Hidden" />
-
-		<!-- Do Not Use Broken Cryptographic Algorithms -->
-		<Rule Id="CA5351" Action="Hidden" />
-	</Rules>
-
 	<Rules AnalyzerId="StyleCop.Analyzers" RuleNamespace="StyleCop.Analyzers.SpacingRules">
 		<!-- Keywords should be spaced correctly -->
 		<Rule Id="SA1000" Action="Hidden" />