From 4bc2f31d7747f0f6487f39abac704437196f4db9 Mon Sep 17 00:00:00 2001 From: YoshiRulz Date: Thu, 27 Mar 2025 05:07:58 +1000 Subject: [PATCH] Simplify `MovieEndPlaySoundMenuItem_Click` fixes 289c5cff9 also standardise these menu items to title case --- src/BizHawk.Client.EmuHawk/MainForm.Designer.cs | 4 ++-- src/BizHawk.Client.EmuHawk/MainForm.Events.cs | 6 +----- 2 files changed, 3 insertions(+), 7 deletions(-) diff --git a/src/BizHawk.Client.EmuHawk/MainForm.Designer.cs b/src/BizHawk.Client.EmuHawk/MainForm.Designer.cs index ee3fdabce0..f724d8bc33 100644 --- a/src/BizHawk.Client.EmuHawk/MainForm.Designer.cs +++ b/src/BizHawk.Client.EmuHawk/MainForm.Designer.cs @@ -827,7 +827,7 @@ namespace BizHawk.Client.EmuHawk // // MovieEndRecordMenuItem // - this.MovieEndRecordMenuItem.Text = "Switch To Record"; + this.MovieEndRecordMenuItem.Text = "Switch to Record"; this.MovieEndRecordMenuItem.Click += new System.EventHandler(this.MovieEndRecordMenuItem_Click); // // MovieEndStopMenuItem @@ -849,7 +849,7 @@ namespace BizHawk.Client.EmuHawk // this.MovieEndPlaySoundMenuItem.Name = "MovieEndPlaySoundMenuItem"; this.MovieEndPlaySoundMenuItem.Size = new System.Drawing.Size(180, 22); - this.MovieEndPlaySoundMenuItem.Text = "Play sound"; + this.MovieEndPlaySoundMenuItem.Text = "Play Sound"; this.MovieEndPlaySoundMenuItem.Click += new System.EventHandler(this.MovieEndPlaySoundMenuItem_Click); // // AVSubMenu diff --git a/src/BizHawk.Client.EmuHawk/MainForm.Events.cs b/src/BizHawk.Client.EmuHawk/MainForm.Events.cs index d1501cca31..b882d10d1b 100644 --- a/src/BizHawk.Client.EmuHawk/MainForm.Events.cs +++ b/src/BizHawk.Client.EmuHawk/MainForm.Events.cs @@ -1628,10 +1628,6 @@ namespace BizHawk.Client.EmuHawk => PathsFromDragDrop = (string[]) e.Data.GetData(DataFormats.FileDrop); private void MovieEndPlaySoundMenuItem_Click(object sender, EventArgs e) - { - MovieEndPlaySoundMenuItem.Checked = !MovieEndPlaySoundMenuItem.Checked; - - Config.Movies.PlaySoundOnMovieEnd = MovieEndPlaySoundMenuItem.Checked; - } + => Config.Movies.PlaySoundOnMovieEnd = !((ToolStripMenuItem) sender).Checked; } }