ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

fix TAStudio input roll display issues 

Resolves the remaining bug mentioned in https://tasvideos.org/Forum/Topics/12519?CurrentPage=85&Highlight=532467#532467
This commit is contained in:
Morilli 2024-12-05 19:28:04 +01:00
parent 29b848d336
commit 49458ab182
1 changed files with 4 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/BizHawk.Client.Common/movie/tasproj/TasMovie.cs
View File

@ -147,13 +147,11 @@ namespace BizHawk.Client.Common
/// </summary>
public string DisplayValue(int frame, string buttonName)
{
// TODO: there are display issues in TAStudio when less than 3 frames are visible
// this is because the Bk2Controller returned from GetInputState is a shared object and mutated elsewhere (like the OSDManager),
// but it's getting cached here. this "works" in the >= 2 frames case because the _displayCache.Frame != frame condition
// will invalidate the cache. Can we do this properly somehow?
if (_displayCache.Frame != frame || FrameCount < 3)
if (_displayCache.Frame != frame)
{
_displayCache = (frame, GetInputState(frame));
_displayCache.Controller ??= new Bk2Controller(Session.MovieController.Definition, LogKey);
_displayCache.Controller.SetFromMnemonic(Log[frame]);
_displayCache.Frame = frame;
}
return CreateDisplayValueForButton(_displayCache.Controller, buttonName);