ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Cleanup dumb LINQ in FirmwareManager

This commit is contained in:
YoshiRulz 2021-02-08 10:55:27 +10:00
parent 7e2437b396
commit 4800fef65e
No known key found for this signature in database
GPG Key ID: C4DE31C245353FB7
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/BizHawk.Client.Common/FirmwareManager.cs
View File

@ -115,14 +115,13 @@ namespace BizHawk.Client.Common
return false;
// weed out filesizes first to reduce the unnecessary overhead of a hashing operation
if (FirmwareDatabase.FirmwareFiles.FirstOrDefault(a => a.Size == fi.Length) == null)
return false;
if (FirmwareDatabase.FirmwareFiles.All(a => a.Size != fi.Length)) return false;
// check the hash
using var reader = new RealFirmwareReader();
reader.Read(fi);
if (FirmwareDatabase.FirmwareFiles.FirstOrDefault(a => a.Hash == reader.Dict.FirstOrDefault().Value.Hash) != null)
return true;
var hash = reader.Dict.Values.First().Hash;
if (FirmwareDatabase.FirmwareFiles.Any(a => a.Hash == hash)) return true;
}
catch { }
@ -245,10 +244,7 @@ namespace BizHawk.Client.Common
ri.KnownFirmwareFile = ff;
// if the known firmware file is for a different firmware, flag it so we can show a warning
var option = FirmwareDatabase.FirmwareOptions
.FirstOrDefault(fo => fo.Hash == rff.Hash && fo.ConfigKey != fr.ConfigKey);
if (option != null)
if (FirmwareDatabase.FirmwareOptions.Any(fo => fo.Hash == rff.Hash && fo.ConfigKey != fr.ConfigKey))
{
ri.KnownMismatching = true;
}