ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

tastudio: revive ColumnsChangedCallback, and alarm if it dies again

This commit is contained in:
feos 2016-11-17 21:30:42 +03:00
parent 2a9bd175d8
commit 433d4ad693
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
BizHawk.Client.EmuHawk/CustomControls/InputRoll.cs
View File

@ -614,6 +614,7 @@ namespace BizHawk.Client.EmuHawk
{
var rollSettings = settings as InputRollSettings;
_columns = rollSettings.Columns;
_columns.ChangedCallback = ColumnChangedCallback;
HorizontalOrientation = rollSettings.HorizontalOrientation;
LagFramesToHide = rollSettings.LagFramesToHide;
HideWasLagFrames = rollSettings.HideWasLagFrames;
@ -2017,10 +2018,11 @@ namespace BizHawk.Client.EmuHawk
private void DoChangeCallback()
{
if (ChangedCallback != null)
{
// no check will make it crash for user too, not sure which way of alarm we prefer. no alarm at all will cause all sorts of subtle bugs
if (ChangedCallback == null)
System.Diagnostics.Debug.Fail("ColumnChangedCallback has died!");
else
ChangedCallback();
}
}
// TODO: this shouldn't be exposed. But in order to not expose it, each RollColumn must have a change callback, and all property changes must call it, it is quicker and easier to just call this when needed