diff --git a/BizHawk.Client.Common/BizHawk.Client.Common.csproj b/BizHawk.Client.Common/BizHawk.Client.Common.csproj index 3abae6b8f2..8238808354 100644 --- a/BizHawk.Client.Common/BizHawk.Client.Common.csproj +++ b/BizHawk.Client.Common/BizHawk.Client.Common.csproj @@ -33,6 +33,9 @@ true + + ..\ICSharpCode.SharpZipLib.dll + ..\Newtonsoft.Json.dll @@ -112,6 +115,7 @@ + diff --git a/BizHawk.MultiClient/XmlGame.cs b/BizHawk.Client.Common/XmlGame.cs similarity index 89% rename from BizHawk.MultiClient/XmlGame.cs rename to BizHawk.Client.Common/XmlGame.cs index c429a94aec..8740535395 100644 --- a/BizHawk.MultiClient/XmlGame.cs +++ b/BizHawk.Client.Common/XmlGame.cs @@ -5,9 +5,7 @@ using System.Text; using System.IO; using System.Xml; -using BizHawk.Client.Common; - -namespace BizHawk.MultiClient +namespace BizHawk.Client.Common { public class XmlGame { @@ -96,10 +94,9 @@ namespace BizHawk.MultiClient } return ret; } - catch (Exception e) + catch(Exception ex) { - System.Windows.Forms.MessageBox.Show(e.ToString(), "XMLGame Load Error"); - return null; + throw new InvalidOperationException(ex.ToString()); } } diff --git a/BizHawk.MultiClient/BizHawk.MultiClient.csproj b/BizHawk.MultiClient/BizHawk.MultiClient.csproj index 4a9978793f..88b6f21ab6 100644 --- a/BizHawk.MultiClient/BizHawk.MultiClient.csproj +++ b/BizHawk.MultiClient/BizHawk.MultiClient.csproj @@ -737,7 +737,6 @@ Component - FFmpegWriterForm.cs diff --git a/BizHawk.MultiClient/MainForm.cs b/BizHawk.MultiClient/MainForm.cs index 445826a724..ac8fd5a7ef 100644 --- a/BizHawk.MultiClient/MainForm.cs +++ b/BizHawk.MultiClient/MainForm.cs @@ -1228,10 +1228,9 @@ namespace BizHawk.MultiClient } else if (file.Extension.ToLower() == ".xml") { - var XMLG = XmlGame.Create(file); - - if (XMLG != null) + try { + var XMLG = XmlGame.Create(file); // if load fails, are we supposed to retry as a bsnes XML???????? game = XMLG.GI; switch (game.System) @@ -1256,9 +1255,11 @@ namespace BizHawk.MultiClient default: return false; } - } - // if load fails, are we supposed to retry as a bsnes XML???????? + catch(Exception ex) + { + System.Windows.Forms.MessageBox.Show(ex.ToString(), "XMLGame Load Error"); + } } else // most extensions {