ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

remove obselete PSX_FirmwaresPath corecomm ref

This commit is contained in:
goyuken 2013-12-21 18:00:38 +00:00
parent d45ba09f50
commit 3c95174e8c
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
BizHawk.Emulation.Common/Interfaces/CoreComms.cs
View File

@ -15,8 +15,6 @@ namespace BizHawk.Emulation.Common
public bool GG_ShowClippedRegions;
public bool GG_HighlightActiveDisplayRegion;
public string PSX_FirmwaresPath;
public ICoreFileProvider CoreFileProvider;
public string SNES_ExePath;

4
BizHawk.Emulation.Cores/Consoles/Sony/PSX/Octoshock.cs
View File

@ -122,6 +122,8 @@ namespace BizHawk.Emulation.Cores.Sony.PSX
static IntPtr FopenCallbackProc(string fname, string mode)
{
throw new NotImplementedException("Antiquated CoreComm.PSX_FirmwaresPath must be replaced by CoreFileProvider");
// TODO - this should be using the CoreComm.CoreFileProvider interfaces
//TODO - probably this should never really fail. but for now, mednafen tries to create a bunch of junk, so just return failure for files which cant be opened
@ -132,7 +134,7 @@ namespace BizHawk.Emulation.Cores.Sony.PSX
if (parts[0] != "$psx") throw new InvalidOperationException("Octoshock using some weird path we dont handle yet");
if (parts[1] == "firmware")
{
fname = Path.Combine(CurrOctoshockCore.CoreComm.PSX_FirmwaresPath, parts[2]);
//fname = Path.Combine(CurrOctoshockCore.CoreComm.PSX_FirmwaresPath, parts[2]);
if (!File.Exists(fname))
{
System.Windows.Forms.MessageBox.Show("the Octoshock core is referencing a firmware file which could not be found. Please make sure it's in your configured PSX firmwares folder. The referenced filename is: " + parts[1]);