Follow attribute class best practices, cleanup docs on attributes

BizHawk.BizInvoke/BizExvoker.cs

@@ -122,23 +122,15 @@ namespace BizHawk.BizInvoke
 		}
 	}
 
-	/// <summary>
+	/// <summary>Indicates that a method is to be exported by BizExvoker.</summary>
-	/// mark an instance method to be exported by BizExvoker
-	/// </summary>
 	[AttributeUsage(AttributeTargets.Method)]
-	public class BizExportAttribute : Attribute
+	public sealed class BizExportAttribute : Attribute
 	{
 		public CallingConvention CallingConvention { get; }
 
-		/// <summary>
+		/// <remarks>The annotated method's name is used iff <see langword="null"/>.</remarks>
-		/// Gets or sets the name of entry point; if not given, the method's name is used
-		/// </summary>
 		public string EntryPoint { get; set; }
 
-		/// <summary>
-		/// Initializes a new instance of the <see cref="BizImportAttribute"/> class. 
-		/// </summary>
-		/// <param name="c">unmanaged calling convention</param>
 		public BizExportAttribute(CallingConvention c)
 		{
 			CallingConvention = c;

BizHawk.BizInvoke/BizInvoker.cs

@@ -537,28 +537,18 @@ namespace BizHawk.BizInvoke
 		}
 	}
 
-	/// <summary>
+	/// <summary>Indicates that an abstract method is to be proxied by BizInvoker.</summary>
-	/// mark an abstract method to be proxied by BizInvoker
-	/// </summary>
 	[AttributeUsage(AttributeTargets.Method)]
-	public class BizImportAttribute : Attribute
+	public sealed class BizImportAttribute : Attribute
 	{
 		public CallingConvention CallingConvention { get; }
 
-		/// <summary>
+		/// <remarks>The annotated method's name is used iff <see langword="null"/>.</remarks>
-		/// Gets or sets the name of entry point; if not given, the method's name is used
-		/// </summary>
 		public string EntryPoint { get; set; }
 
-		/// <summary>
+		/// <summary><see langword="true"/> iff a compatibility interop should be used, which is slower but supports more argument types.</summary>
-		/// Gets or sets a value indicating whether or not to use a slower interop that supports more argument types
-		/// </summary>
 		public bool Compatibility { get; set; }
 
-		/// <summary>
-		/// Initializes a new instance of the <see cref="BizImportAttribute"/> class. 
-		/// </summary>
-		/// <param name="c">unmanaged calling convention</param>
 		public BizImportAttribute(CallingConvention c)
 		{
 			CallingConvention = c;

BizHawk.Client.ApiHawk/Classes/ApiInjector.cs

@@ -68,12 +68,12 @@ namespace BizHawk.Client.ApiHawk
 	}
 
 	[AttributeUsage(AttributeTargets.Property)]
-	public class RequiredApiAttribute : Attribute
+	public sealed class RequiredApiAttribute : Attribute
 	{
 	}
 
 	[AttributeUsage(AttributeTargets.Property)]
-	public class OptionalApiAttribute : Attribute
+	public sealed class OptionalApiAttribute : Attribute
 	{
 	}
 }

BizHawk.Client.Common/Api/ExternalToolAttributes.cs

@@ -96,13 +96,12 @@ namespace BizHawk.Client.Common
 	[AttributeUsage(AttributeTargets.Class)]
 	public sealed class ExternalToolAttribute : Attribute
 	{
-		public readonly string Description;
+		public string Description { get; set; }
 
 		public readonly string Name;
 
-		public ExternalToolAttribute(string name, string description = null)
+		public ExternalToolAttribute(string name)
 		{
-			Description = description;
 			Name = string.IsNullOrWhiteSpace(name) ? Guid.NewGuid().ToString() : name;
 		}
 

BizHawk.Client.Common/BinarySaveStates.cs

@@ -69,7 +69,7 @@ namespace BizHawk.Client.Common
 		public static BinaryStateLump BranchUserText { get; private set; }
 
 		[AttributeUsage(AttributeTargets.Property)]
-		private class NameAttribute : Attribute
+		private sealed class NameAttribute : Attribute
 		{
 			public string Name { get; }
 			public string Ext { get; }

BizHawk.Client.Common/config/ConfigPersistAttribute.cs

@@ -2,11 +2,9 @@
 
 namespace BizHawk.Client.Common
 {
-	/// <summary>
+	/// <summary>Indicates that a property is to be saved to config for persistence.</summary>
-	/// Define if the property has to be persisted in config
-	/// </summary>
 	[AttributeUsage(AttributeTargets.Property)]
-	public class ConfigPersistAttribute : Attribute
+	public sealed class ConfigPersistAttribute : Attribute
 	{
 	}
 }

BizHawk.Client.Common/config/RestoreDefaultsAttribute.cs

@@ -2,11 +2,10 @@
 
 namespace BizHawk.Client.Common
 {
-	/// <summary>
+	/// <summary>Indicates which method of an <see cref="IToolFormAutoConfig"/> is to be called when the generated <c>Restore Defaults</c> menu item is clicked.</summary>
-	/// Defines a method to be called when a tool dialog's Restore Defaults method is called
+	/// <remarks>If not present on any instance method, the menu item will do nothing. If present on multiple, the first will be called.</remarks>
-	/// </summary>
 	[AttributeUsage(AttributeTargets.Method)]
-	public class RestoreDefaultsAttribute : Attribute
+	public sealed class RestoreDefaultsAttribute : Attribute
 	{
 	}
 }

BizHawk.Client.Common/lua/LuaAttributes.cs

@@ -3,7 +3,7 @@
 namespace BizHawk.Client.Common
 {
 	[AttributeUsage(AttributeTargets.Method)]
-	public class LuaMethodAttribute : Attribute
+	public sealed class LuaMethodAttribute : Attribute
 	{
 		public LuaMethodAttribute(string name, string description)
 		{
@@ -16,7 +16,7 @@ namespace BizHawk.Client.Common
 	}
 
 	[AttributeUsage(AttributeTargets.Method)]
-	public class LuaMethodExampleAttribute : Attribute
+	public sealed class LuaMethodExampleAttribute : Attribute
 	{
 		public LuaMethodExampleAttribute(string example)
 		{
@@ -27,7 +27,7 @@ namespace BizHawk.Client.Common
 	}
 
 	[AttributeUsage(AttributeTargets.Class)]
-	public class LuaLibraryAttribute : Attribute
+	public sealed class LuaLibraryAttribute : Attribute
 	{
 		public LuaLibraryAttribute(bool released)
 		{

BizHawk.Client.Common/movie/import/IMovieImport.cs

@@ -101,7 +101,7 @@ namespace BizHawk.Client.Common
 	}
 
 	[AttributeUsage(AttributeTargets.Class)]
-	public class ImporterForAttribute : Attribute
+	public sealed class ImporterForAttribute : Attribute
 	{
 		public ImporterForAttribute(string emulator, string extension)
 		{

BizHawk.Client.EmuHawk/AVOut/IVideoWriter.cs

@@ -99,7 +99,7 @@ namespace BizHawk.Client.EmuHawk
 	}
 
 	[AttributeUsage(AttributeTargets.Class)]
-	public class VideoWriterAttribute : Attribute
+	public sealed class VideoWriterAttribute : Attribute
 	{
 		public string ShortName { get; }
 		public string Name { get; }
@@ -114,7 +114,7 @@ namespace BizHawk.Client.EmuHawk
 	}
 
 	[AttributeUsage(AttributeTargets.Class)]
-	public class VideoWriterIgnoreAttribute : Attribute
+	public sealed class VideoWriterIgnoreAttribute : Attribute
 	{
 	}
 

BizHawk.Client.EmuHawk/ToolAttribute.cs

@@ -5,15 +5,17 @@ using System.Linq;
 namespace BizHawk.Client.EmuHawk
 {
 	[AttributeUsage(AttributeTargets.Class)]
-	public class ToolAttribute : Attribute
+	public sealed class ToolAttribute : Attribute
 	{
-		public ToolAttribute(bool released, string[] supportedSystems, string[] unsupportedCores = null)
+		public ToolAttribute(bool released, string[] supportedSystems, string[] unsupportedCores)
 		{
 			Released = released;
 			SupportedSystems = supportedSystems ?? Enumerable.Empty<string>();
 			UnsupportedCores = unsupportedCores ?? Enumerable.Empty<string>();
 		}
 
+		public ToolAttribute(bool released, string[] supportedSystems) : this(released, supportedSystems, null) {}
+
 		public bool Released { get; }
 
 		public IEnumerable<string> SupportedSystems { get; }

BizHawk.Client.EmuHawk/tools/VirtualPads/schema/SchemaAttribute.cs

@@ -3,11 +3,8 @@
 namespace BizHawk.Client.EmuHawk
 {
 	[AttributeUsage(AttributeTargets.Class)]
-	public class SchemaAttribute : Attribute
+	public sealed class SchemaAttribute : Attribute
 	{
-		/// <summary>
-		/// Gets the system id associated with this schema
-		/// </summary>
 		public string SystemId { get; }
 
 		public SchemaAttribute(string systemId)

BizHawk.Common/DeepEquality.cs

@@ -7,11 +7,9 @@ using System.Reflection;
 
 namespace BizHawk.Common
 {
-	/// <summary>
+	/// <summary>Annotated fields will not be used by <see cref="DeepEquality"/> for comparison.</summary>
-	/// causes DeepEquality to ignore this field when determining equality
-	/// </summary>
 	[AttributeUsage(AttributeTargets.Field)]
-	public class DeepEqualsIgnoreAttribute : Attribute
+	public sealed class DeepEqualsIgnoreAttribute : Attribute
 	{
 	}
 

BizHawk.Emulation.Common/Base Implementations/NullEmulator.cs

@@ -1,8 +1,21 @@
 namespace BizHawk.Emulation.Common
 {
 	[Core("NullHawk", "", false, true)]
-	[ServiceNotApplicable(typeof(IStatable), typeof(ISaveRam), typeof(IDriveLight), typeof(ICodeDataLogger), typeof(IMemoryDomains), typeof(ISettable<,>),
+	[ServiceNotApplicable(new[] {
-		typeof(IDebuggable), typeof(IDisassemblable), typeof(IInputPollable), typeof(IRegionable), typeof(ITraceable), typeof(IBoardInfo), typeof(ISoundProvider))]
+		typeof(IBoardInfo),
+		typeof(ICodeDataLogger),
+		typeof(IDebuggable),
+		typeof(IDisassemblable),
+		typeof(IDriveLight),
+		typeof(IInputPollable),
+		typeof(IMemoryDomains),
+		typeof(IRegionable),
+		typeof(ISaveRam),
+		typeof(ISettable<,>),
+		typeof(ISoundProvider),
+		typeof(IStatable),
+		typeof(ITraceable)
+	})]
 	public class NullEmulator : IEmulator, IVideoProvider
 	{
 		private readonly int[] _frameBuffer = new int[NullVideo.DefaultWidth * NullVideo.DefaultHeight];

BizHawk.Emulation.Common/CoreAttribute.cs

@@ -3,26 +3,22 @@
 namespace BizHawk.Emulation.Common
 {
 	[AttributeUsage(AttributeTargets.Class)]
-	public class CoreAttribute : Attribute
+	public sealed class CoreAttribute : Attribute
 	{
-		public CoreAttribute(
+		public CoreAttribute(string name, string author, bool isPorted, bool isReleased, string portedVersion, string portedUrl, bool singleInstance)
-			string name,
-			string author,
-			bool isPorted = false,
-			bool isReleased = false,
-			string portedVersion = "",
-			string portedUrl = "",
-			bool singleInstance = false)
 		{
 			CoreName = name;
 			Author = author;
 			Ported = isPorted;
 			Released = isReleased;
-			PortedVersion = portedVersion;
+			PortedVersion = portedVersion ?? string.Empty;
-			PortedUrl = portedUrl;
+			PortedUrl = portedUrl ?? string.Empty;
 			SingleInstance = singleInstance;
 		}
 
+		public CoreAttribute(string name, string author, bool isPorted, bool isReleased)
+			: this(name, author, isPorted, isReleased, null, null, false) {}
+
 		public string CoreName { get; }
 		public string Author { get; }
 		public bool Ported { get; }

BizHawk.Emulation.Common/ServiceAttributes.cs

@@ -4,26 +4,27 @@ using System.Linq;
 
 namespace BizHawk.Emulation.Common
 {
-	/// <summary>
+	/// <summary>Indicates that a method (or property getter/setter) inherited from a <see cref="IEmulatorService"/> has yet to be implemented.</summary>
-	/// Should be added to any field of an IEmulatorService that is not implemented.
+	/// <remarks>
-	/// By Convention it should also throw a NotImplementedException
+	/// By convention, calling a method with this attribute should throw a <see cref="NotImplementedException"/>.
-	/// Any feature that does not have this attribute is assumed to be implemented
+	/// If this attribute is not present on an implementation, it is assumed that the method is implemented and working.
-	/// </summary>
+	/// </remarks>
-	public class FeatureNotImplementedAttribute : Attribute
+	[AttributeUsage(AttributeTargets.Method | AttributeTargets.Property)]
+	public sealed class FeatureNotImplementedAttribute : Attribute
 	{
 	}
 
-	/// <summary>
+	/// <summary>Indicates that a class intentionally does not inherit from the specified <see cref="IEmulatorService">IEmulatorServices</see>, and will never do so.</summary>
-	/// Should be added to any implementation of IEmulator to document any
+	/// <remarks>
-	/// IEmulatorService (that is not an ISpecializedEmulatorService) that
+	/// <see cref="ISpecializedEmulatorService">ISpecializedEmulatorServices</see> that a core doesn't implement should not be listed, as the semantic of only being applicable to some cores is already clear.<br/>
-	/// by design, will not be implemented by the core
+	/// Any <see cref="IEmulatorService"/> which isn't specified and is also not implemented is assumed to be a work-in-progress.
-	/// Any service that is unimplemented and not marked with this attribute is
+	/// These should be implemented as soon as possible, simply throwing a <see cref="NotImplementedException"/> on call, and should be annotated with <see cref="FeatureNotImplementedAttribute"/>.
-	/// assumed to be a "TODO" that needs to be done but hasn't been done yet
+	/// </remarks>
-	/// </summary>
 	[AttributeUsage(AttributeTargets.Class)]
-	public class ServiceNotApplicableAttribute : Attribute
+	public sealed class ServiceNotApplicableAttribute : Attribute
 	{
-		public ServiceNotApplicableAttribute(params Type[] types)
+		/// <remarks>TODO neither array nor <see cref="IEnumerable{T}"/> is the correct collection to be using here, try <see cref="IReadOnlyList{T}"/>/<see cref="IReadOnlyCollection{T}"/> instead</remarks>
+		public ServiceNotApplicableAttribute(Type[] types)
 		{
 			NotApplicableTypes = types?.AsEnumerable() ?? Enumerable.Empty<Type>();
 		}

BizHawk.Emulation.Common/ServiceInjector.cs

@@ -68,12 +68,12 @@ namespace BizHawk.Emulation.Common
 	}
 
 	[AttributeUsage(AttributeTargets.Property)]
-	public class RequiredServiceAttribute : Attribute
+	public sealed class RequiredServiceAttribute : Attribute
 	{
 	}
 
 	[AttributeUsage(AttributeTargets.Property)]
-	public class OptionalServiceAttribute : Attribute
+	public sealed class OptionalServiceAttribute : Attribute
 	{
 	}
 }

BizHawk.Emulation.Cores/Arcades/MAME/MAME.cs

@@ -15,6 +15,7 @@ namespace BizHawk.Emulation.Cores.Arcades.MAME
 		name: "MAME",
 		author: "MAMEDev",
 		isPorted: true,
+		isReleased: false,
 		portedVersion: "0.217",
 		portedUrl: "https://github.com/mamedev/mame.git",
 		singleInstance: false)]

BizHawk.Emulation.Cores/Calculator/TI83.cs

@@ -10,7 +10,7 @@ namespace BizHawk.Emulation.Cores.Calculators
 		"zeromus",
 		isPorted: false,
 		isReleased: true)]
-	[ServiceNotApplicable(typeof(ISoundProvider), typeof(ISaveRam), typeof(IRegionable), typeof(IDriveLight), typeof(IBoardInfo))]
+	[ServiceNotApplicable(new[] { typeof(IBoardInfo), typeof(IDriveLight), typeof(IRegionable), typeof(ISaveRam), typeof(ISoundProvider) })]
 	public partial class TI83 : IEmulator, IVideoProvider, IDebuggable, IInputPollable, ISettable<TI83.TI83Settings, object>
 	{
 		[CoreConstructor("TI83")]

BizHawk.Emulation.Cores/Computers/AppleII/AppleII.cs

@@ -11,7 +11,7 @@ namespace BizHawk.Emulation.Cores.Computers.AppleII
 		"fool",
 		isPorted: true,
 		isReleased: true)]
-	[ServiceNotApplicable(typeof(ISaveRam), typeof(IRegionable), typeof(IBoardInfo))]
+	[ServiceNotApplicable(new[] { typeof(IBoardInfo), typeof(IRegionable), typeof(ISaveRam) })]
 	public partial class AppleII : IEmulator, ISoundProvider, IVideoProvider, IStatable, IDriveLight
 	{
 		static AppleII()

BizHawk.Emulation.Cores/Computers/MSX/MSX.cs

@@ -9,7 +9,7 @@ namespace BizHawk.Emulation.Cores.Computers.MSX
 		"",
 		isPorted: false,
 		isReleased: false)]
-	[ServiceNotApplicable(typeof(IDriveLight))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight) })]
 	public partial class MSX : IEmulator, IVideoProvider, ISoundProvider, ISaveRam, IInputPollable, IRegionable, ISettable<MSX.MSXSettings, MSX.MSXSyncSettings>
 	{
 		[CoreConstructor("MSX")]

BizHawk.Emulation.Cores/Consoles/Atari/2600/Atari2600.cs

@@ -11,7 +11,7 @@ namespace BizHawk.Emulation.Cores.Atari.Atari2600
 		"Micro500, Alyosha, adelikat, natt",
 		isPorted: false,
 		isReleased: true)]
-	[ServiceNotApplicable(typeof(ISaveRam), typeof(IDriveLight))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight), typeof(ISaveRam) })]
 	public partial class Atari2600 : IEmulator, IDebuggable, IInputPollable, IBoardInfo,
 		IRegionable, ICreateGameDBEntries, ISettable<Atari2600.A2600Settings, Atari2600.A2600SyncSettings>
 	{

BizHawk.Emulation.Cores/Consoles/Atari/A7800Hawk/A7800Hawk.cs

@@ -12,7 +12,7 @@ namespace BizHawk.Emulation.Cores.Atari.A7800Hawk
 		"",
 		isPorted: false,
 		isReleased: true)]
-	[ServiceNotApplicable(typeof(ISettable<,>), typeof(IDriveLight))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight), typeof(ISettable<,>) })]
 	public partial class A7800Hawk : IEmulator, ISaveRam, IDebuggable, IInputPollable,
 		IRegionable, IBoardInfo, ISettable<A7800Hawk.A7800Settings, A7800Hawk.A7800SyncSettings>
 	{

BizHawk.Emulation.Cores/Consoles/Atari/lynx/Lynx.cs

@@ -6,8 +6,8 @@ using BizHawk.Emulation.Common;
 
 namespace BizHawk.Emulation.Cores.Atari.Lynx
 {
-	[Core("Handy", "K. Wilkins, Mednafen Team", true, true, "mednafen 0-9-34-1", "http://mednafen.sourceforge.net/")]
+	[Core("Handy", "K. Wilkins, Mednafen Team", true, true, "mednafen 0-9-34-1", "http://mednafen.sourceforge.net/", false)]
-	[ServiceNotApplicable(typeof(ISettable<,>), typeof(IDriveLight), typeof(IRegionable))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight), typeof(IRegionable), typeof(ISettable<,>) })]
 	public partial class Lynx : IEmulator, IVideoProvider, ISoundProvider, ISaveRam, IStatable, IInputPollable
 	{
 		[CoreConstructor("Lynx")]

BizHawk.Emulation.Cores/Consoles/Coleco/ColecoVision.cs

@@ -9,7 +9,7 @@ namespace BizHawk.Emulation.Cores.ColecoVision
 		"Vecna",
 		isPorted: false,
 		isReleased: true)]
-	[ServiceNotApplicable(typeof(ISaveRam), typeof(IDriveLight))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight), typeof(ISaveRam) })]
 	public sealed partial class ColecoVision : IEmulator, IDebuggable, IInputPollable, ISettable<ColecoVision.ColecoSettings, ColecoVision.ColecoSyncSettings>
 	{
 		[CoreConstructor("Coleco")]

BizHawk.Emulation.Cores/Consoles/Fairchild/ChannelF/ChannelF.cs

@@ -8,7 +8,7 @@ namespace BizHawk.Emulation.Cores.Consoles.ChannelF
 		"Asnivor",
 		isPorted: false,
 		isReleased: false)]
-	[ServiceNotApplicable(typeof(IDriveLight))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight) })]
 	public partial class ChannelF
 	{
 		public ChannelF(CoreComm comm, GameInfo game, byte[] rom, object settings, object syncSettings)

BizHawk.Emulation.Cores/Consoles/GCE/Vectrex/VectrexHawk.cs

@@ -11,7 +11,7 @@ namespace BizHawk.Emulation.Cores.Consoles.Vectrex
 		"",
 		isPorted: false,
 		isReleased: true)]
-	[ServiceNotApplicable(typeof(IDriveLight))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight) })]
 	public partial class VectrexHawk : IEmulator, ISaveRam, IDebuggable, IInputPollable, IRegionable, 
 	ISettable<VectrexHawk.VectrexSettings, VectrexHawk.VectrexSyncSettings>
 	{

BizHawk.Emulation.Cores/Consoles/Intellivision/Intellivision.cs

@@ -10,7 +10,7 @@ namespace BizHawk.Emulation.Cores.Intellivision
 		"BrandonE, Alyosha",
 		isPorted: false,
 		isReleased: true)]
-	[ServiceNotApplicable(typeof(ISaveRam), typeof(IDriveLight), typeof(IRegionable))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight), typeof(IRegionable), typeof(ISaveRam) })]
 	public sealed partial class Intellivision : IEmulator, IInputPollable, IDisassemblable,
 		IBoardInfo, IDebuggable, ISettable<Intellivision.IntvSettings, Intellivision.IntvSyncSettings>
 	{

BizHawk.Emulation.Cores/Consoles/Magnavox/Odyssey2/O2Hawk.cs

@@ -11,7 +11,7 @@ namespace BizHawk.Emulation.Cores.Consoles.O2Hawk
 		"",
 		isPorted: false,
 		isReleased: false)]
-	[ServiceNotApplicable(typeof(IDriveLight))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight) })]
 	public partial class O2Hawk : IEmulator, ISaveRam, IDebuggable, IInputPollable, IRegionable, ISettable<O2Hawk.O2Settings, O2Hawk.O2SyncSettings>
 	{
 		// memory domains

BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/MGBAHawk.cs

@@ -5,7 +5,7 @@ using BizHawk.Emulation.Common;
 namespace BizHawk.Emulation.Cores.Nintendo.GBA
 {
 	[Core("mGBA", "endrift", true, true, "0.8", "https://mgba.io/", false)]
-	[ServiceNotApplicable(typeof(IDriveLight), typeof(IRegionable))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight), typeof(IRegionable) })]
 	public partial class MGBAHawk : IEmulator, IVideoProvider, ISoundProvider, IGBAGPUViewable,
 		ISaveRam, IStatable, IInputPollable, ISettable<MGBAHawk.Settings, MGBAHawk.SyncSettings>,
 		IDebuggable

BizHawk.Emulation.Cores/Consoles/Nintendo/GBA/VBANext.cs

@@ -7,8 +7,8 @@ using BizHawk.Emulation.Cores.Components.ARM;
 
 namespace BizHawk.Emulation.Cores.Nintendo.GBA
 {
-	[Core("VBA-Next", "many authors", true, true, "cd508312a29ed8c29dacac1b11c2dce56c338a54", "https://github.com/libretro/vba-next")]
+	[Core("VBA-Next", "many authors", true, true, "cd508312a29ed8c29dacac1b11c2dce56c338a54", "https://github.com/libretro/vba-next", false)]
-	[ServiceNotApplicable(typeof(IDriveLight), typeof(IRegionable))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight), typeof(IRegionable) })]
 	public partial class VBANext : IEmulator, IVideoProvider, ISoundProvider, IInputPollable,
 		IGBAGPUViewable, ISaveRam, IStatable, IDebuggable, ISettable<object, VBANext.SyncSettings>
 	{

BizHawk.Emulation.Cores/Consoles/Nintendo/GBHawk/GBHawk.cs

@@ -14,7 +14,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.GBHawk
 		"",
 		isPorted: false,
 		isReleased: true)]
-	[ServiceNotApplicable(typeof(IDriveLight))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight) })]
 	public partial class GBHawk : IEmulator, ISaveRam, IDebuggable, IInputPollable, IRegionable, IGameboyCommon,
 	ISettable<GBHawk.GBSettings, GBHawk.GBSyncSettings>
 	{
@@ -84,7 +84,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.GBHawk
 
 		private static byte[] GBA_override = { 0xFF, 0x00, 0xCD, 0x03, 0x35, 0xAA, 0x31, 0x90, 0x94, 0x00, 0x00, 0x00, 0x00 };
 
-		[CoreConstructor("GB", "GBC")]
+		[CoreConstructor(new[] { "GB", "GBC" })]
 		public GBHawk(CoreComm comm, GameInfo game, byte[] rom, /*string gameDbFn,*/ object settings, object syncSettings)
 		{
 			var ser = new BasicServiceProvider(this);

BizHawk.Emulation.Cores/Consoles/Nintendo/GBHawkLink/GBHawkLink.cs

@@ -7,7 +7,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.GBHawkLink
 		"",
 		isPorted: false,
 		isReleased: true)]
-	[ServiceNotApplicable(typeof(IDriveLight))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight) })]
 	public partial class GBHawkLink : IEmulator, ISaveRam, IDebuggable, IStatable, IInputPollable, IRegionable, ILinkable,
 	ISettable<GBHawkLink.GBLinkSettings, GBHawkLink.GBLinkSyncSettings>
 	{

BizHawk.Emulation.Cores/Consoles/Nintendo/GBHawkLink3x/GBHawkLink3x.cs

@@ -7,7 +7,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.GBHawkLink3x
 		"",
 		isPorted: false,
 		isReleased: true)]
-	[ServiceNotApplicable(typeof(IDriveLight))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight) })]
 	public partial class GBHawkLink3x : IEmulator, ISaveRam, IDebuggable, IStatable, IInputPollable, IRegionable,
 	ISettable<GBHawkLink3x.GBLink3xSettings, GBHawkLink3x.GBLink3xSyncSettings>
 	{

BizHawk.Emulation.Cores/Consoles/Nintendo/GBHawkLink4x/GBHawkLink4x.cs

@@ -7,7 +7,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.GBHawkLink4x
 		"",
 		isPorted: false,
 		isReleased: false)]
-	[ServiceNotApplicable(typeof(IDriveLight))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight) })]
 	public partial class GBHawkLink4x : IEmulator, ISaveRam, IDebuggable, IStatable, IInputPollable, IRegionable,
 	ISettable<GBHawkLink4x.GBLink4xSettings, GBHawkLink4x.GBLink4xSyncSettings>
 	{

BizHawk.Emulation.Cores/Consoles/Nintendo/Gameboy/Gambatte.cs

@@ -15,13 +15,14 @@ namespace BizHawk.Emulation.Cores.Nintendo.Gameboy
 		isPorted: true,
 		isReleased: true,
 		portedVersion: "SVN 344",
-		portedUrl: "http://gambatte.sourceforge.net/")]
+		portedUrl: "http://gambatte.sourceforge.net/",
-	[ServiceNotApplicable(typeof(IDriveLight), typeof(IDriveLight))]
+		singleInstance: false)]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight) })]
 	public partial class Gameboy : IEmulator, IVideoProvider, ISoundProvider, ISaveRam, IStatable, IInputPollable, ICodeDataLogger,
 		IBoardInfo, IDebuggable, ISettable<Gameboy.GambatteSettings, Gameboy.GambatteSyncSettings>,
 		IGameboyCommon, ICycleTiming, ILinkable
 	{
-		[CoreConstructor("GB", "GBC")]
+		[CoreConstructor(new[] { "GB", "GBC" })]
 		public Gameboy(CoreComm comm, GameInfo game, byte[] file, object settings, object syncSettings, bool deterministic)
 		{
 			var ser = new BasicServiceProvider(this);

BizHawk.Emulation.Cores/Consoles/Nintendo/Gameboy/GambatteLink.cs

@@ -7,7 +7,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.Gameboy
 		"sinamas/natt",
 		isPorted: true,
 		isReleased: true)]
-	[ServiceNotApplicable(typeof(IDriveLight))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight) })]
 	public partial class GambatteLink : IEmulator, IVideoProvider, ISoundProvider, IInputPollable, ISaveRam, IStatable, ILinkable,
 		IBoardInfo, IDebuggable, ISettable<GambatteLink.GambatteLinkSettings, GambatteLink.GambatteLinkSyncSettings>, ICodeDataLogger
 	{

BizHawk.Emulation.Cores/Consoles/Nintendo/N64/N64.cs

@@ -14,7 +14,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.N64
 		portedVersion: "2.0",
 		portedUrl: "https://code.google.com/p/mupen64plus/",
 		singleInstance: true)]
-	[ServiceNotApplicable(typeof(IDriveLight))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight) })]
 	public partial class N64 : IEmulator, ISaveRam, IDebuggable, IStatable, IInputPollable, IDisassemblable, IRegionable,
 		ISettable<N64Settings, N64SyncSettings>
 	{

BizHawk.Emulation.Cores/Consoles/Nintendo/NES/NES.BoardSystem.cs

@@ -341,14 +341,14 @@ namespace BizHawk.Emulation.Cores.Nintendo.NES
 
 		//this will be used to track classes that implement boards
 		[AttributeUsage(AttributeTargets.Class)]
-		public class INESBoardImplAttribute : Attribute { }
+		public sealed class INESBoardImplAttribute : Attribute { }
 		//this tracks derived boards that shouldnt be used by the implementation scanner
 		[AttributeUsage(AttributeTargets.Class)]
-		public class INESBoardImplCancelAttribute : Attribute { }
+		public sealed class INESBoardImplCancelAttribute : Attribute { }
 		static List<Type> INESBoardImplementors = new List<Type>();
 		//flags it as being priority, i.e. in the top of the list
 		[AttributeUsage(AttributeTargets.Class)]
-		public class INESBoardImplPriorityAttribute : Attribute { }
+		public sealed class INESBoardImplPriorityAttribute : Attribute { }
 
 		static INESBoard CreateBoardInstance(Type boardType)
 		{
@@ -736,7 +736,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.NES
 	}
 
 	[AttributeUsage(AttributeTargets.Field)]
-	public class MapperPropAttribute : Attribute
+	public sealed class MapperPropAttribute : Attribute
 	{
 		public string Name { get; }
 

BizHawk.Emulation.Cores/Consoles/Nintendo/QuickNES/QuickNES.cs

@@ -16,8 +16,9 @@ namespace BizHawk.Emulation.Cores.Consoles.Nintendo.QuickNES
 		isPorted: true,
 		isReleased: true,
 		portedVersion: "0.7.0",
-		portedUrl: "https://github.com/kode54/QuickNES")]
+		portedUrl: "https://github.com/kode54/QuickNES",
-	[ServiceNotApplicable(typeof(IDriveLight))]
+		singleInstance: false)]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight) })]
 	public partial class QuickNES : IEmulator, IVideoProvider, ISoundProvider, ISaveRam, IInputPollable, IBoardInfo,
 		IStatable, IDebuggable, ISettable<QuickNES.QuickNESSettings, QuickNES.QuickNESSyncSettings>, Cores.Nintendo.NES.INESPPUViewable
 	{

BizHawk.Emulation.Cores/Consoles/Nintendo/SNES/LibsnesCore.cs

@@ -23,8 +23,9 @@ namespace BizHawk.Emulation.Cores.Nintendo.SNES
 		isPorted: true,
 		isReleased: true,
 		portedVersion: "v87",
-		portedUrl: "http://byuu.org/")]
+		portedUrl: "http://byuu.org/",
-	[ServiceNotApplicable(typeof(IDriveLight))]
+		singleInstance: false)]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight) })]
 	public unsafe partial class LibsnesCore : IEmulator, IVideoProvider, ISaveRam, IStatable, IInputPollable, IRegionable, ICodeDataLogger,
 		IDebuggable, ISettable<LibsnesCore.SnesSettings, LibsnesCore.SnesSyncSettings>
 	{

BizHawk.Emulation.Cores/Consoles/Nintendo/SNES9X/Snes9x.cs

@@ -11,7 +11,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.SNES9X
 {
 	[Core("Snes9x", "", true, true,
 		"5e0319ab3ef9611250efb18255186d0dc0d7e125", "https://github.com/snes9xgit/snes9x", false)]
-	[ServiceNotApplicable(typeof(IDriveLight))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight) })]
 	public class Snes9x : WaterboxCore, 
 		ISettable<Snes9x.Settings, Snes9x.SyncSettings>, IRegionable
 	{

BizHawk.Emulation.Cores/Consoles/Nintendo/SubNESHawk/SubNESHawk.cs

@@ -11,7 +11,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.SubNESHawk
 		"",
 		isPorted: false,
 		isReleased: true)]
-	[ServiceNotApplicable(typeof(IDriveLight))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight) })]
 	public partial class SubNESHawk : IEmulator, ISaveRam, IDebuggable, IStatable, IInputPollable, IRegionable,
 		IBoardInfo, ISettable<NES.NES.NESSettings, NES.NES.NESSyncSettings>, INESPPUViewable
 	{

BizHawk.Emulation.Cores/Consoles/PC Engine/PCEngine.cs

@@ -19,7 +19,7 @@ namespace BizHawk.Emulation.Cores.PCEngine
 	public sealed partial class PCEngine : IEmulator, ISaveRam, IInputPollable,
 		IDebuggable, ISettable<PCEngine.PCESettings, PCEngine.PCESyncSettings>, IDriveLight, ICodeDataLogger
 	{
-		[CoreConstructor("PCE", "SGX")]
+		[CoreConstructor(new[] { "PCE", "SGX" })]
 		public PCEngine(CoreComm comm, GameInfo game, byte[] rom, object settings, object syncSettings)
 		{
 			CoreComm = comm;

BizHawk.Emulation.Cores/Consoles/Sega/GGHawkLink/GGHawkLink.cs

@@ -8,7 +8,7 @@ namespace BizHawk.Emulation.Cores.Sega.GGHawkLink
 		"",
 		isPorted: false,
 		isReleased: false)]
-	[ServiceNotApplicable(typeof(IDriveLight))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight) })]
 	public partial class GGHawkLink : IEmulator, ISaveRam, IDebuggable, IStatable, IInputPollable, IRegionable, ILinkable,
 	ISettable<GGHawkLink.GGLinkSettings, GGHawkLink.GGLinkSyncSettings>
 	{

BizHawk.Emulation.Cores/Consoles/Sega/SMS/SMS.cs

@@ -19,11 +19,11 @@ namespace BizHawk.Emulation.Cores.Sega.MasterSystem
 		"Vecna",
 		isPorted: false,
 		isReleased: true)]
-	[ServiceNotApplicable(typeof(IDriveLight))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight) })]
 	public partial class SMS : IEmulator, ISaveRam, IInputPollable, IRegionable,
 		IDebuggable, ISettable<SMS.SmsSettings, SMS.SmsSyncSettings>, ICodeDataLogger
 	{
-		[CoreConstructor("SMS", "SG", "GG")]
+		[CoreConstructor(new[] { "SMS", "SG", "GG" })]
 		public SMS(CoreComm comm, GameInfo game, byte[] rom, object settings, object syncSettings)
 		{
 			ServiceProvider = new BasicServiceProvider(this);

BizHawk.Emulation.Cores/Consoles/Sony/PSP/PSP.cs

@@ -10,6 +10,8 @@ namespace BizHawk.Emulation.Cores.Sony.PSP
 		"hrydgard",
 		isPorted: true,
 		isReleased: false,
+		portedVersion: null,
+		portedUrl: null,
 		singleInstance: true)]
 	public class PSP : IEmulator, IVideoProvider, ISoundProvider
 	{

BizHawk.Emulation.Cores/Consoles/WonderSwan/WonderSwan.cs

@@ -6,8 +6,8 @@ using BizHawk.Emulation.Common;
 
 namespace BizHawk.Emulation.Cores.WonderSwan
 {
-	[Core("Cygne/Mednafen", "Dox, Mednafen Team", true, true, "0.9.36.5", "http://mednafen.sourceforge.net/")]
+	[Core("Cygne/Mednafen", "Dox, Mednafen Team", true, true, "0.9.36.5", "http://mednafen.sourceforge.net/", false)]
-	[ServiceNotApplicable(typeof(IDriveLight), typeof(IRegionable))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight), typeof(IRegionable) })]
 	public partial class WonderSwan : IEmulator, IVideoProvider, ISoundProvider,
 		IInputPollable, IDebuggable
 	{

BizHawk.Emulation.Cores/CoreInventory.cs

@@ -177,15 +177,21 @@ namespace BizHawk.Emulation.Cores
 	}
 
 	[AttributeUsage(AttributeTargets.Constructor)]
-	public class CoreConstructorAttribute : Attribute
+	public sealed class CoreConstructorAttribute : Attribute
 	{
 		private readonly List<string> _systems = new List<string>();
 
-		public CoreConstructorAttribute(params string[] systems)
+		/// <remarks>TODO neither array nor <see cref="IEnumerable{T}"/> is the correct collection to be using here, try <see cref="IReadOnlyList{T}"/>/<see cref="IReadOnlyCollection{T}"/> instead</remarks>
+		public CoreConstructorAttribute(string[] systems)
 		{
 			_systems.AddRange(systems);
 		}
 
+		public CoreConstructorAttribute(string system)
+		{
+			_systems.Add(system);
+		}
+
 		public IEnumerable<string> Systems => _systems;
 	}
 }

BizHawk.Emulation.Cores/Libretro/LibretroCore.cs

@@ -11,8 +11,8 @@ using BizHawk.Emulation.Common;
 
 namespace BizHawk.Emulation.Cores.Libretro
 {
-	[Core("Libretro", "zeromus")]
+	[Core("Libretro", "zeromus", isPorted: false, isReleased: false)]
-	[ServiceNotApplicable(typeof(IDriveLight))]
+	[ServiceNotApplicable(new[] { typeof(IDriveLight) })]
 	public unsafe partial class LibretroCore : IEmulator, ISettable<LibretroCore.Settings, LibretroCore.SyncSettings>,
 		ISaveRam, IStatable, IVideoProvider, IInputPollable
 	{