ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Use `SortedDictionary` for `FirmwareConfig.Status{Descs,Icons}`

This commit is contained in:
YoshiRulz 2024-12-26 00:54:18 +10:00
parent 9b72b2292e
commit 31dd2dbd2f
No known key found for this signature in database
GPG Key ID: C4DE31C245353FB7
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/BizHawk.Client.EmuHawk/config/FirmwareConfig.cs
View File

@ -29,7 +29,7 @@ namespace BizHawk.Client.EmuHawk
{ {
private const string STATUS_DESC_UNUSED = ""; private const string STATUS_DESC_UNUSED = "";
private static readonly IReadOnlyDictionary<FirmwareOptionStatus, string> StatusDescs = new Dictionary<FirmwareOptionStatus, string> private static readonly IReadOnlyDictionary<FirmwareOptionStatus, string> StatusDescs = new SortedDictionary<FirmwareOptionStatus, string>
{ {
[FirmwareOptionStatus.Unset] = STATUS_DESC_UNUSED, [FirmwareOptionStatus.Unset] = STATUS_DESC_UNUSED,
[FirmwareOptionStatus.Bad] = "BAD! Why are you using this file", [FirmwareOptionStatus.Bad] = "BAD! Why are you using this file",
@ -39,7 +39,7 @@ namespace BizHawk.Client.EmuHawk
[FirmwareOptionStatus.Ideal] = "PERFECT: Ideal for TASing and anything", [FirmwareOptionStatus.Ideal] = "PERFECT: Ideal for TASing and anything",
}; };
internal static readonly IReadOnlyDictionary<FirmwareOptionStatus, Image> StatusIcons = new Dictionary<FirmwareOptionStatus, Image> internal static readonly IReadOnlyDictionary<FirmwareOptionStatus, Image> StatusIcons = new SortedDictionary<FirmwareOptionStatus, Image>
{ {
[FirmwareOptionStatus.Unset] = Properties.Resources.FFhelp, [FirmwareOptionStatus.Unset] = Properties.Resources.FFhelp,
[FirmwareOptionStatus.Bad] = Properties.Resources.FFdelete, [FirmwareOptionStatus.Bad] = Properties.Resources.FFdelete,
@ -145,7 +145,7 @@ namespace BizHawk.Client.EmuHawk
= tbbOpenFolder.Image = Properties.Resources.Placeholder; = tbbOpenFolder.Image = Properties.Resources.Placeholder;
// prep ImageList for ListView // prep ImageList for ListView
foreach (var kvp in StatusIcons.OrderBy(static kvp => kvp.Key)) imageList1.Images.Add(kvp.Value); foreach (var img in StatusIcons.Values) imageList1.Images.Add(img);
_listViewSorter = new ListViewSorter(-1); _listViewSorter = new ListViewSorter(-1);

3
src/BizHawk.Client.EmuHawk/config/FirmwareConfigInfo.cs
View File

@ -1,4 +1,3 @@
using System.Linq;
using System.Windows.Forms; using System.Windows.Forms;
// todo - display details on the current resolution status // todo - display details on the current resolution status
@ -13,7 +12,7 @@ namespace BizHawk.Client.EmuHawk
InitializeComponent(); InitializeComponent();
// prep imagelist for listview // prep imagelist for listview
foreach (var kvp in FirmwareConfig.StatusIcons.OrderBy(static kvp => kvp.Key)) imageList1.Images.Add(kvp.Value); foreach (var img in FirmwareConfig.StatusIcons.Values) imageList1.Images.Add(img);
} }
private void LvOptions_KeyDown(object sender, KeyEventArgs e) private void LvOptions_KeyDown(object sender, KeyEventArgs e)