From 3017459a3a38471a0bb1dc185b2df6cc8053477c Mon Sep 17 00:00:00 2001
From: YoshiRulz <OSSYoshiRulz+git@gmail.com>
Date: Wed, 16 Apr 2025 23:12:28 +1000
Subject: [PATCH] Mute remaining MSTest usage warnings

---
 .../Client.Common/Movie/ZwinderStateManagerTests.cs           | 1 -
 src/BizHawk.Tests/Client.Common/lua/LuaTests.cs               | 4 ++++
 src/BizHawk.Tests/TestAssertions.cs                           | 2 ++
 3 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/BizHawk.Tests/Client.Common/Movie/ZwinderStateManagerTests.cs b/src/BizHawk.Tests/Client.Common/Movie/ZwinderStateManagerTests.cs
index ef0471e78f..a9cfddae4e 100644
--- a/src/BizHawk.Tests/Client.Common/Movie/ZwinderStateManagerTests.cs
+++ b/src/BizHawk.Tests/Client.Common/Movie/ZwinderStateManagerTests.cs
@@ -283,7 +283,6 @@ namespace BizHawk.Tests.Client.Common.Movie
 			var actual = zw.GetStateClosestToFrame(futureReservedFrame + 1);
 
 			// Assert
-			Assert.IsNotNull(actual);
 			Assert.AreEqual(futureReservedFrame, actual.Key);
 		}
 
diff --git a/src/BizHawk.Tests/Client.Common/lua/LuaTests.cs b/src/BizHawk.Tests/Client.Common/lua/LuaTests.cs
index 19e60ffe11..da21844852 100644
--- a/src/BizHawk.Tests/Client.Common/lua/LuaTests.cs
+++ b/src/BizHawk.Tests/Client.Common/lua/LuaTests.cs
@@ -1,3 +1,5 @@
+#pragma warning disable MSTEST0037 // wants `Assert.IsTrue` calls to be more specific
+
 using System.Collections.Generic;
 using System.Drawing;
 using System.Linq;
@@ -88,7 +90,9 @@ namespace BizHawk.Tests.Client.Common.Lua
 
 		[LuaMethod("pass_color", "")]
 		public static void PassColor(object? o)
+#pragma warning disable MSTEST0026 // "Prefer adding an additional assertion that checks for null" ??? maybe structure like the below method?
 			=> Assert.IsTrue(_th.SafeParseColor(o)?.ToArgb() == ((Color?)ExpectedValue)?.ToArgb());
+#pragma warning restore MSTEST0026
 
 		[LuaMethod("pass_table", "")]
 		public static void PassTable(NLua.LuaTable? o)
diff --git a/src/BizHawk.Tests/TestAssertions.cs b/src/BizHawk.Tests/TestAssertions.cs
index a465dc79b7..6fa0b4fde3 100644
--- a/src/BizHawk.Tests/TestAssertions.cs
+++ b/src/BizHawk.Tests/TestAssertions.cs
@@ -65,7 +65,9 @@ namespace BizHawk.Tests
 			this CollectionAssert assert,
 			IReadOnlyCollection<T> collection,
 			string? message = null)
+#pragma warning disable MSTEST0037 // intentionally not using `Assert.AreEqual` here as the "ex: 0, ac: 4" message might be confusing
 				=> Assert.IsTrue(collection.Count is 0, message);
+#pragma warning restore MSTEST0037
 
 		/// <remarks>dumb param order matches predefined method</remarks>
 		public static void IsSubsetOf<T>(