clearsaveram() internal infrastructure changes

BizHawk.Client.Common/movie/bkm/BkmMovie.ModeApi.cs

@@ -34,11 +34,16 @@ namespace BizHawk.Client.Common
 			// If Starting a new recording requires clearing sram it shoudl be done at a higher layer and not rely on all IMovies doing this
 			// Haven't removed it yet because I coudln't guarantee that power-on movies coudl live without it
 			// And the immediate fire is that Savestate movies are breaking
+
+			/*
+			 * natt: in light of more recent changes, the front end is no longer errantly loading saveram for new movies.  so, as best as i
+			 * can tell through snaking through the debugger, this is no longer needed.
+			 *
 			if (!StartsFromSavestate)
 			{
 				Global.Emulator.ClearSaveRam();
 			}
-
+			*/
 			_mode = Moviemode.Record;
 			if (Global.Config.EnableBackupMovies && _makeBackup && _log.Any())
 			{
@@ -51,11 +56,12 @@ namespace BizHawk.Client.Common
 
 		public void StartNewPlayback()
 		{
-			// See StartNewRecording for details as to why this savestate check is here
+			// See StartNewRecording for details as to why this code is gone
+			/*
 			if (!StartsFromSavestate)
 			{
 				Global.Emulator.ClearSaveRam();
-			}
+			}*/
 
 			_mode = Moviemode.Play;
 		}

BizHawk.Emulation.Common/Interfaces/IEmulator.cs

@@ -89,7 +89,7 @@ namespace BizHawk.Emulation.Common
 		void StoreSaveRam(byte[] data);
 
 		/// <summary>
-		/// reset saveram to a standard initial state
+		/// reset saveram to a standard initial state.  this probably shouldn't be used; instantiate a new core to clear persistent things.
 		/// </summary>
 		void ClearSaveRam();