Don't invoke UB with possibly unaligned memory

2024-09-11 16:24:13 -07:00 · 2024-09-11 16:24:13 -07:00 · 245f0e2271
parent 3b62a38f1d
commit 245f0e2271
1 changed files with 2 additions and 1 deletions
--- a/src/BizHawk.Client.EmuHawk/RetroAchievements/RetroAchievements.GameVerification.cs
+++ b/src/BizHawk.Client.EmuHawk/RetroAchievements/RetroAchievements.GameVerification.cs
@ -431,7 +431,8 @@ namespace BizHawk.Client.EmuHawk
 					return true;
 				}

-				var programId = MemoryMarshal.GetReference(Util.UnsafeSpanFromPointer<ulong>(ptr: optional_program_id, count: 1));
+				var programId = MemoryMarshal.Read<ulong>(
+					Util.UnsafeSpanFromPointer<byte>(ptr: optional_program_id, count: 8));

 				FirmwareID seeddbFWID = new("3DS", "seeddb");
 				using BinaryReader seeddb = new(GetFirmware(seeddbFWID));