diff --git a/src/BizHawk.Client.EmuHawk/RetroAchievements/RetroAchievements.GameVerification.cs b/src/BizHawk.Client.EmuHawk/RetroAchievements/RetroAchievements.GameVerification.cs index 63e3e9c919..58bfac9ee1 100644 --- a/src/BizHawk.Client.EmuHawk/RetroAchievements/RetroAchievements.GameVerification.cs +++ b/src/BizHawk.Client.EmuHawk/RetroAchievements/RetroAchievements.GameVerification.cs @@ -385,7 +385,7 @@ namespace BizHawk.Client.EmuHawk } var programId = BinaryPrimitives.ReadUInt64LittleEndian( - Util.UnsafeSpanFromPointer(ptr: optional_program_id, count: 8)); + Util.UnsafeSpanFromPointer(ptr: optional_program_id, length: 8)); FirmwareID seeddbFWID = new("3DS", "seeddb"); using BinaryReader seeddb = new(GetFirmware(seeddbFWID)); diff --git a/src/BizHawk.Common/Util.cs b/src/BizHawk.Common/Util.cs index 9347e4b588..ee2d2ed43b 100644 --- a/src/BizHawk.Common/Util.cs +++ b/src/BizHawk.Common/Util.cs @@ -293,17 +293,19 @@ namespace BizHawk.Common return new(pointer: ptr.ToPointer(), length: length); } +#if false // unused /// /// creates span over * sizeof() octets /// starting at /// - /// uses native endianness + /// uses native endianness and must be aligned (else UB) [MethodImpl(MethodImplOptions.AggressiveInlining)] - public static unsafe Span UnsafeSpanFromPointer(IntPtr ptr, int count) + public static unsafe Span UnsafeSpanFromPointerAligned(IntPtr ptr, int count) where T : unmanaged { return new(pointer: ptr.ToPointer(), length: count * sizeof(T)); } +#endif public static void WriteByteBuffer(this BinaryWriter bw, byte[]? data) {