From 23c1ccac7eb86718438ea158e2362e7e88f1dcf6 Mon Sep 17 00:00:00 2001
From: adelikat <adelikat@tasvideos.org>
Date: Sun, 24 May 2020 14:07:47 -0500
Subject: [PATCH] BkmControllerAdapter - simplify and get rid of legacy support
 for random buttons, not such a good idea on an importer

---
 .../movie/import/bkm/BkmControllerAdapter.cs  | 30 ++-----------------
 1 file changed, 2 insertions(+), 28 deletions(-)

diff --git a/src/BizHawk.Client.Common/movie/import/bkm/BkmControllerAdapter.cs b/src/BizHawk.Client.Common/movie/import/bkm/BkmControllerAdapter.cs
index 171b11e4d8..3b33b03c9c 100644
--- a/src/BizHawk.Client.Common/movie/import/bkm/BkmControllerAdapter.cs
+++ b/src/BizHawk.Client.Common/movie/import/bkm/BkmControllerAdapter.cs
@@ -1,6 +1,4 @@
-using System;
-
-using BizHawk.Common;
+using BizHawk.Common;
 using BizHawk.Emulation.Common;
 
 namespace BizHawk.Client.Common
@@ -55,9 +53,6 @@ namespace BizHawk.Client.Common
 				case "Saturn Controller":
 					SetSaturnControllersAsMnemonic(mnemonic);
 					return;
-				case "PSP Controller":
-					// TODO
-					return;
 				case "GPGX Genesis Controller":
 				{
 					if (IsGenesis6Button())
@@ -569,28 +564,7 @@ namespace BizHawk.Client.Common
 				_mnemonic = mnemonic;
 			}
 
-			public bool this[int c]
-			{
-				get
-				{
-					if (string.IsNullOrEmpty(_mnemonic))
-					{
-						return false;
-					}
-
-					if (_mnemonic[c] == '.')
-					{
-						return false;
-					}
-
-					if (_mnemonic[c] == '?')
-					{
-						return new Random((int)DateTime.Now.Ticks).Next(0, 10) > 5;
-					}
-
-					return true;
-				}
-			}
+			public bool this[int c] => !string.IsNullOrEmpty(_mnemonic) && _mnemonic[c] != '.';
 		}
 	}
 }