From 201a4b85a4b202f0c2f7f650343aaac63db872ea Mon Sep 17 00:00:00 2001 From: warmCabin <35278529+warmCabin@users.noreply.github.com> Date: Wed, 11 Dec 2019 12:44:54 -0500 Subject: [PATCH] remove default value for address The reason we throw an error originally is my concern is that it would be easy to leave out an address in a script, and that it would have huge concequences. I think address should not have a default value here and make the user explicitly add nil if they want this functionality. --- BizHawk.Client.Common/lua/EmuLuaLibrary.Events.cs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/BizHawk.Client.Common/lua/EmuLuaLibrary.Events.cs b/BizHawk.Client.Common/lua/EmuLuaLibrary.Events.cs index 073724d987..4bbc58f34f 100644 --- a/BizHawk.Client.Common/lua/EmuLuaLibrary.Events.cs +++ b/BizHawk.Client.Common/lua/EmuLuaLibrary.Events.cs @@ -183,9 +183,9 @@ namespace BizHawk.Client.Common return nlf.Guid.ToString(); } - [LuaMethodExample("local steveonm = event.onmemoryexecute(\r\n\tfunction()\r\n\t\tconsole.log( \"Fires after the given address is executed by the core. If no address is given, it will attach to every memory read\" );\r\n\tend\r\n\t, 0x200, \"Frame name\", \"System Bus\" );")] - [LuaMethod("onmemoryexecute", "Fires after the given address is executed by the core. If no address is given, it will attach to every memory read")] - public string OnMemoryExecute(LuaFunction luaf, uint? address = null, string name = null, string domain = null) + [LuaMethodExample("local steveonm = event.onmemoryexecute(\r\n\tfunction()\r\n\t\tconsole.log( \"Fires after the given address is executed by the core. If is explicitly nil, it will attach to every memory read\" );\r\n\tend\r\n\t, 0x200, \"Frame name\", \"System Bus\" );")] + [LuaMethod("onmemoryexecute", "Fires after the given address is executed by the core. If the address is explicitly nil, it will attach to every memory read")] + public string OnMemoryExecute(LuaFunction luaf, uint? address, string name = null, string domain = null) { try {