From 1f7d75b7d24f7715f622f63a876813f830eff2fd Mon Sep 17 00:00:00 2001 From: YoshiRulz Date: Thu, 4 Jul 2024 06:36:57 +1000 Subject: [PATCH] Enable MA0044 and fix noncompliance "Remove useless ToString call" (on a `string`) --- .global.editorconfig.ini | 2 +- src/BizHawk.Emulation.Cores/CPUs/ARM/Darm.cs | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/.global.editorconfig.ini b/.global.editorconfig.ini index 22d2f09999..74183c5e33 100644 --- a/.global.editorconfig.ini +++ b/.global.editorconfig.ini @@ -187,7 +187,7 @@ dotnet_diagnostic.MA0042.severity = error # Use nameof operator in ArgumentException dotnet_diagnostic.MA0043.severity = error # Remove useless ToString call -dotnet_diagnostic.MA0044.severity = silent +dotnet_diagnostic.MA0044.severity = warning # Do not use blocking call in a sync method (need to make containing method async) dotnet_diagnostic.MA0045.severity = silent # Use EventHandler to declare events diff --git a/src/BizHawk.Emulation.Cores/CPUs/ARM/Darm.cs b/src/BizHawk.Emulation.Cores/CPUs/ARM/Darm.cs index a8dbdd8afc..7769abf10e 100644 --- a/src/BizHawk.Emulation.Cores/CPUs/ARM/Darm.cs +++ b/src/BizHawk.Emulation.Cores/CPUs/ARM/Darm.cs @@ -98,7 +98,6 @@ namespace BizHawk.Emulation.Cores.Components.ARM if (Str(d, s, false)) return null; string[] ret = Encoding.ASCII.GetString(s.total, 0, Array.IndexOf(s.total, (byte)0)) - .ToString() .Split(new string[] {" "}, 2, StringSplitOptions.None); return ret[0].PadRight(8) + (ret.Length > 1 ? ret[1] : ""); }