From 1f1bf9b056fcf41f04a4407baacd679789a181f2 Mon Sep 17 00:00:00 2001 From: Morilli <35152647+Morilli@users.noreply.github.com> Date: Sun, 15 Sep 2024 21:29:51 +0200 Subject: [PATCH] Comment out nonfunctional cycle count update code setting cycle count in HandleFrameAfter could work, but needs proper invalidation logic --- src/BizHawk.Client.Common/movie/MovieSession.cs | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/BizHawk.Client.Common/movie/MovieSession.cs b/src/BizHawk.Client.Common/movie/MovieSession.cs index f89734b072..cd8cf22917 100644 --- a/src/BizHawk.Client.Common/movie/MovieSession.cs +++ b/src/BizHawk.Client.Common/movie/MovieSession.cs @@ -335,6 +335,7 @@ namespace BizHawk.Client.Common Debug.Assert(Movie.IsPlaying()); Debug.Assert(Movie.Emulator.Frame >= Movie.InputLogLength); #endif +#if false // code below doesn't actually do anything as the cycle count is indiscriminately overwritten (or removed) on save anyway. if (Movie.IsAtEnd() && Movie.Emulator.HasCycleTiming()) { const string WINDOW_TITLE_MISMATCH = "Cycle count mismatch"; @@ -384,6 +385,7 @@ namespace BizHawk.Client.Common } } } +#endif switch (Settings.MovieEndAction) { case MovieEndAction.Stop: