From 16d1782c9ee1240412289aeadd81ba94b0525033 Mon Sep 17 00:00:00 2001
From: YoshiRulz <OSSYoshiRulz@gmail.com>
Date: Thu, 18 Jun 2020 03:40:32 +1000
Subject: [PATCH] Enable CA1018 and fix noncompliance

"Mark attributes with AttributeUsageAttribute"
---
 Common.ruleset                                          | 3 ---
 src/BizHawk.Client.Common/Api/ExternalToolAttributes.cs | 1 +
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/Common.ruleset b/Common.ruleset
index fa3401f545..b53ccc1aa3 100644
--- a/Common.ruleset
+++ b/Common.ruleset
@@ -32,9 +32,6 @@
 		<!-- Mark assemblies with assembly version -->
 		<Rule Id="CA1016" Action="Hidden" />
 
-		<!-- Mark attributes with AttributeUsageAttribute -->
-		<Rule Id="CA1018" Action="Hidden" />
-
 		<!-- Enum Storage should be Int32 -->
 		<Rule Id="CA1028" Action="Hidden" />
 
diff --git a/src/BizHawk.Client.Common/Api/ExternalToolAttributes.cs b/src/BizHawk.Client.Common/Api/ExternalToolAttributes.cs
index 098c6683d7..6151de41b5 100644
--- a/src/BizHawk.Client.Common/Api/ExternalToolAttributes.cs
+++ b/src/BizHawk.Client.Common/Api/ExternalToolAttributes.cs
@@ -118,6 +118,7 @@ namespace BizHawk.Client.Common
 		}
 	}
 
+	[AttributeUsage(AttributeTargets.Class)]
 	public sealed class ExternalToolEmbeddedIconAttribute : Attribute
 	{
 		/// <remarks>The full path, including the assembly name.</remarks>