From 15f69cf80ee7b03b328e84daef2079d8bbe850f3 Mon Sep 17 00:00:00 2001 From: adelikat Date: Tue, 28 Apr 2020 17:12:50 -0500 Subject: [PATCH] put bad code back in that keeps a stopped movie hanging around in memory, until tastudio is refactored. This "fixes" a lot of crash bugs when opening movies with tastudio --- BizHawk.Client.Common/movie/MovieSession.cs | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/BizHawk.Client.Common/movie/MovieSession.cs b/BizHawk.Client.Common/movie/MovieSession.cs index cbed778a8c..1d03f02453 100644 --- a/BizHawk.Client.Common/movie/MovieSession.cs +++ b/BizHawk.Client.Common/movie/MovieSession.cs @@ -355,7 +355,10 @@ namespace BizHawk.Client.Common MultiTrack.Restart(_emulator.ControllerDefinition.PlayerCount); _modeChangedCallback(); - Movie = MovieService.Create(); + + // TODO: we aren't ready for this line, keeping the old movie hanging around masks a lot of Tastudio problems + // Uncommenting this can cause drawing crashes in tastudio since it depends on a ITasMovie and doesn't have one between closing and opening a rom + //Movie = MovieService.Create(); } public void ConvertToTasProj()