From 099bee6bf5dc3f775ec3be069b72e89b05151d90 Mon Sep 17 00:00:00 2001 From: adelikat Date: Fri, 24 Apr 2020 13:51:59 -0500 Subject: [PATCH] fix off by one error in BulkReadByte fixes #1944 --- BizHawk.Emulation.Common/Base Implementations/MemoryDomain.cs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/BizHawk.Emulation.Common/Base Implementations/MemoryDomain.cs b/BizHawk.Emulation.Common/Base Implementations/MemoryDomain.cs index 29d19bc633..b717f10c4e 100644 --- a/BizHawk.Emulation.Common/Base Implementations/MemoryDomain.cs +++ b/BizHawk.Emulation.Common/Base Implementations/MemoryDomain.cs @@ -113,7 +113,7 @@ namespace BizHawk.Emulation.Common throw new InvalidOperationException("Invalid length of values array"); } - for (var i = addresses.Start; i < addresses.EndInclusive; i++) + for (var i = addresses.Start; i <= addresses.EndInclusive; i++) { values[i - addresses.Start] = PeekByte(i); } @@ -133,7 +133,7 @@ namespace BizHawk.Emulation.Common throw new InvalidOperationException("Invalid length of values array"); } - for (var i = 0; i