ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix bank switching in NesHawk's MMC5 impl. w/ 128 KiB WRAM

This commit is contained in:
YoshiRulz 2025-04-09 10:45:57 +10:00
parent f58644cb5a
commit 06bf689e8d
No known key found for this signature in database
GPG Key ID: C4DE31C245353FB7
1 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/BizHawk.Emulation.Cores/Consoles/Nintendo/NES/Boards/ExROM.cs
View File

@ -1,3 +1,7 @@
#if DEBUG
using System.Diagnostics;
#endif
using BizHawk.Common; using BizHawk.Common;
using BizHawk.Emulation.Common; using BizHawk.Emulation.Common;
using BizHawk.Emulation.Cores.Components; using BizHawk.Emulation.Cores.Components;
@ -169,7 +173,9 @@ namespace BizHawk.Emulation.Cores.Nintendo.NES
// for iNES, we assume 64K wram // for iNES, we assume 64K wram
private int? MaskWRAM(int bank) private int? MaskWRAM(int bank)
{ {
bank &= 7; #if DEBUG
if (bank < 0 || (Cart.WramSize is 128 ? 0xF : 0x7) < bank) throw new ArgumentOutOfRangeException(paramName: nameof(bank), bank, message: "invalid bank index");
#endif
switch (Cart.WramSize) switch (Cart.WramSize)
{ {
case 0: case 0:
@ -521,7 +527,7 @@ namespace BizHawk.Emulation.Cores.Nintendo.NES
case 0x1113: //$5113: [.... .PPP] (simplified, but technically inaccurate -- see below) case 0x1113: //$5113: [.... .PPP] (simplified, but technically inaccurate -- see below)
wram_bank = value & 7; wram_bank = value & (Cart.WramSize is 128 ? 0b1111 : 0b0111);
break; break;
//$5114-5117: [RPPP PPPP] PRG select //$5114-5117: [RPPP PPPP] PRG select