From 06bb89791f16708de912ddaf6eceeaafba21141b Mon Sep 17 00:00:00 2001
From: adelikat <adelikat@tasvideos.org>
Date: Sun, 18 Nov 2018 10:05:06 -0600
Subject: [PATCH] Add a nag when attempting to record a quicknes movie (but
 allow the user to continue), fixes #1353

---
 BizHawk.Client.EmuHawk/MainForm.Events.cs     | 25 ++++++++++++++++++
 .../tools/TAStudio/TAStudio.cs                | 26 +++++++++++++++++++
 2 files changed, 51 insertions(+)

diff --git a/BizHawk.Client.EmuHawk/MainForm.Events.cs b/BizHawk.Client.EmuHawk/MainForm.Events.cs
index 6899bca58d..314c2adaaa 100644
--- a/BizHawk.Client.EmuHawk/MainForm.Events.cs
+++ b/BizHawk.Client.EmuHawk/MainForm.Events.cs
@@ -501,6 +501,31 @@ namespace BizHawk.Client.EmuHawk
 					// Do nothing and allow the user to continue to record the movie
 				}
 			}
+			else if (Emulator is QuickNES) // This is unsustainable :( But mixing the logic together is even worse, this needs to be rethought
+			{
+				var box = new MsgBox(
+					"While the QuickNes core is faster, it is not nearly as accurate as NesHawk. \nIt is recommended that you switch to the NesHawk core for movie recording\nSwitch to NesHawk?",
+					"Accuracy Warning",
+					MessageBoxIcon.Warning);
+
+				box.SetButtons(
+					new[] { "Switch", "Continue" },
+					new[] { DialogResult.Yes, DialogResult.Cancel });
+
+				box.MaximumSize = new Size(475, 350);
+				box.SetMessageToAutoSize();
+				var result = box.ShowDialog();
+
+				if (result == DialogResult.Yes)
+				{
+					Global.Config.NES_InQuickNES = false;
+					RebootCore();
+				}
+				else if (result == DialogResult.Cancel)
+				{
+					// Do nothing and allow the user to continue to record the movie
+				}
+			}
 
 			new RecordMovie(Emulator).ShowDialog();
 		}
diff --git a/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs b/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs
index d5df9f3f15..8d3f2d0b6f 100644
--- a/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs
+++ b/BizHawk.Client.EmuHawk/tools/TAStudio/TAStudio.cs
@@ -15,6 +15,7 @@ using BizHawk.Client.Common.MovieConversionExtensions;
 
 using BizHawk.Client.EmuHawk.WinFormExtensions;
 using BizHawk.Client.EmuHawk.ToolExtensions;
+using BizHawk.Emulation.Cores.Consoles.Nintendo.QuickNES;
 
 namespace BizHawk.Client.EmuHawk
 {
@@ -341,6 +342,31 @@ namespace BizHawk.Client.EmuHawk
 					//return false;
 				}
 			}
+			else if (Emulator is QuickNES) // Copy pasta of unsustainable logic, even better
+			{
+				var box = new CustomControls.MsgBox(
+					"While the QuickNes core is faster, it is not nearly as accurate as NesHawk. \nIt is recommended that you switch to the NesHawk core for movie recording\nSwitch to NesHawk?",
+					"Accuracy Warning",
+					MessageBoxIcon.Warning);
+
+				box.SetButtons(
+					new[] { "Switch", "Continue" },
+					new[] { DialogResult.Yes, DialogResult.Cancel });
+
+				box.MaximumSize = new Size(475, 350);
+				box.SetMessageToAutoSize();
+				var result = box.ShowDialog();
+
+				if (result == DialogResult.Yes)
+				{
+					Global.Config.NES_InQuickNES = false;
+					Mainform.RebootCore();
+				}
+				else if (result == DialogResult.Cancel)
+				{
+					//return false;
+				}
+			}
 
 			// Start Scenario 1: A regular movie is active
 			if (Global.MovieSession.Movie.IsActive && !(Global.MovieSession.Movie is TasMovie))