ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Now that SGB is the BoardName, don't save a SGB row in the movie header

This commit is contained in:
adelikat 2014-06-12 21:27:49 +00:00
parent aee94afe05
commit 05b3f369eb
3 changed files with 3 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
BizHawk.Client.Common/movie/HeaderKeys.cs
View File

@ -24,10 +24,6 @@ namespace BizHawk.Client.Common
// Core Setting
public const string CORE = "Core";
// Gameboy Settings that affect sync
// TODO: movie import references these but it shoudl be populating sync settings instead
public const string SGB = "SGB"; // A snes movie will set this to indicate that it's actually SGB
// Plugin Settings
public const string VIDEOPLUGIN = "VideoPlugin";

4
BizHawk.Client.Common/movie/MovieImport.cs
View File

@ -1119,7 +1119,9 @@ namespace BizHawk.Client.Common
case "sgb_ntsc":
case "sgb_pal":
platform = "SNES";
m.Header[HeaderKeys.SGB] = "True";
// Movies 2.0 TODO: populating this flag wasn't doing anything useful
// Figure out how to properly set sync settings to set it to sgb
//m.Header[HeaderKeys.SGB] = "True";
break;
}
bool pal = (gametype == "snes_pal" || gametype == "sgb_pal");

6
BizHawk.Client.EmuHawk/movie/RecordMovie.cs
View File

@ -134,12 +134,6 @@ namespace BizHawk.Client.EmuHawk
}
}
if (Global.Emulator is LibsnesCore)
{
// TODO: shouldn't the Boardname property have sgb?
_movieToRecord.HeaderEntries[HeaderKeys.SGB] = (Global.Emulator as LibsnesCore).IsSGB.ToString();
}
_movieToRecord.Core = ((CoreAttributes)Attribute
.GetCustomAttribute(Global.Emulator.GetType(), typeof(CoreAttributes)))
.CoreName;