From 019562501c5f416f491256cd1606d69e64a86efc Mon Sep 17 00:00:00 2001 From: goyuken Date: Wed, 25 Jun 2014 15:42:57 +0000 Subject: [PATCH] add a few helpful comments to clarify r6998 --- BizHawk.Client.EmuHawk/config/ControllerConfig.cs | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/BizHawk.Client.EmuHawk/config/ControllerConfig.cs b/BizHawk.Client.EmuHawk/config/ControllerConfig.cs index b0e9279784..c584d714aa 100644 --- a/BizHawk.Client.EmuHawk/config/ControllerConfig.cs +++ b/BizHawk.Client.EmuHawk/config/ControllerConfig.cs @@ -107,6 +107,9 @@ namespace BizHawk.Client.EmuHawk buckets[i] = new List(); } + // by iterating through only the controller's active buttons, we're silently + // discarding anything that's not on the controller right now. due to the way + // saving works, those entries will still be preserved in the config file, tho foreach (var button in controllerButtons) { int i; @@ -380,6 +383,8 @@ namespace BizHawk.Client.EmuHawk private void ButtonSaveDefaults_Click(object sender, EventArgs e) { + // this doesn't work anymore, as it stomps out any defaults for buttons that aren't currently active on the console + // there are various ways to fix it, each with its own semantic problems var result = MessageBox.Show(this, "OK to overwrite defaults for current control scheme?", "Save Defaults", MessageBoxButtons.YesNo); if (result == DialogResult.Yes) {