From 00e0a5fb2a1e86ec4b0105d6b12768e13061a767 Mon Sep 17 00:00:00 2001 From: CasualPokePlayer <50538166+CasualPokePlayer@users.noreply.github.com> Date: Wed, 25 Oct 2023 22:55:46 -0700 Subject: [PATCH] fix default value arrays source generation this change doesn't actually do anything since we don't even have arrays in default values --- .../DefaultSetterGenerator.cs | 4 ++-- References/BizHawk.SrcGen.SettingsUtil.dll | Bin 12800 -> 12800 bytes 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/ExternalProjects/BizHawk.SrcGen.SettingsUtil/DefaultSetterGenerator.cs b/ExternalProjects/BizHawk.SrcGen.SettingsUtil/DefaultSetterGenerator.cs index 77151014e5..5bc21d9209 100644 --- a/ExternalProjects/BizHawk.SrcGen.SettingsUtil/DefaultSetterGenerator.cs +++ b/ExternalProjects/BizHawk.SrcGen.SettingsUtil/DefaultSetterGenerator.cs @@ -58,9 +58,9 @@ public class DefaultSetterGenerator : ISourceGenerator // this single arg is just the value assigned to the default value var arg = ctorArgs.Value[0]; // a bit lame, but it'll work - // TODO: do we even want to handle arrays? do we even have any arrays in default values??? + // TODO: do we even want to handle arrays? we don't even have arrays in default values... var converionStr = arg.Kind == TypedConstantKind.Array - ? $"new {arg.Type} " // new T[] + ? $"new {arg.Type}[] " // new T[] : ""; // do we need a cast (i.e. (T)) here? probably not? source.Append($@" settings.{prop.Name} = {converionStr}{arg.ToCSharpString()};"); diff --git a/References/BizHawk.SrcGen.SettingsUtil.dll b/References/BizHawk.SrcGen.SettingsUtil.dll index 94a2b3fafaed891a13fb089a42e86478ea2d4c91..926863c62bbcf8e537c9e9f7a0985ce7dca5ac9c 100644 GIT binary patch delta 404 zcmZojX-JvS!NUIK-}8w*GK^jmSB5iwoy^Fn&dTA=zz{N7kx6HAB%?ZGz~n~8dPdF3 zj7-9;0*VX_jFSVk%r^%x2{PICGB6Y@QWfXO*JohhTBIsbv=S^JDaf`+RZ5Um!vHKS zU9=G-tYHY`sw*aIYAFflMFhXymaNHZ`9FaX)^p`I>4 zI%IPwN123>XdXiy5 z1FWLT1&T)*7<~hPW-=53aSSjZVkXOKinE>rvd&Gm)KnJubobe^`P=XNO?K!I4AQ%r zJUK@*RTnDQ2NMJu;Ncqb2$J2 delta 407 zcmZojX-JvS!6Nx`=bwo^GK_8$SB5iwoXp6m&dTD>zz{N7kx6HAB%?Z`&*VnNdPddB zj7-9;Jc;aNbm>3w8LxUL{q!}0l7=Uc|P)`>i z9k4l+qfCNNFpnXXp`1a1p_;*fp?33Kg?J_bi`=3uT+x5r8iRhSv3+H;+w7x!fK_zn z^OAN3M&AISc??BB903f3h{=kY;;g5DtW%S1HI)TI+b