ShuriZma
/
BizHawk
mirror of https://github.com/TASEmulators/BizHawk.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

BSNESv115: remove autoJoypad condition in lag detection code 

this fixes lag frame detection in Super Bomber Man (Japan) and didn't cause any regression in my limited testing
This commit is contained in:
Morilli 2023-01-08 22:29:12 +01:00
parent abee97b449
commit 00060c3ffa
3 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

BIN
Assets/dll/bsnes.wbx.zst
View File

Binary file not shown.

4
waterbox/bsnescore/bsnes/sfc/cpu/io.cpp
View File

@ -16,7 +16,7 @@ auto CPU::readCPU(uint addr, uint8 data) -> uint8 {
case 0x4016: //JOYSER0
data &= 0xfc;
data |= controllerPort1.device->data();
if (!io.autoJoypadPoll) platform->notify("NO_LAG");
platform->notify("NO_LAG");
return data;
//todo: it is not known what happens when reading from this register during auto-joypad polling
@ -24,7 +24,7 @@ auto CPU::readCPU(uint addr, uint8 data) -> uint8 {
data &= 0xe0;
data |= 0x1c; //pins are connected to GND
data |= controllerPort2.device->data();
if (!io.autoJoypadPoll) platform->notify("NO_LAG");
platform->notify("NO_LAG");
return data;
case 0x4210: //RDNMI

1
waterbox/bsnescore/bsnes/target-bsnescore/bsnescore.cpp
View File

@ -208,7 +208,6 @@ EXPORT void snes_load_cartridge_normal(
program->load();
}
// TODO: merged_rom_sizes is bad, fix this
EXPORT void snes_load_cartridge_super_gameboy(
const uint8_t* rom_data, const uint8_t* sgb_rom_data, int rom_size, int sgb_rom_size
) {